poanetwork / poa-popa

DApp for proof of physical address (PoPA) attestation for validators of POA Network
https://popa.poa.network
GNU General Public License v3.0
24 stars 18 forks source link

Refactor unregister address method #154

Closed fvictorio closed 6 years ago

fvictorio commented 6 years ago

Closes #149. Closes #155.

Note that this will do an unnecessary assignment when the user removes the last address, but I'm not sure if adding a conditional is worth it.

I also added more tests to be sure that it's working as expected.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 478


Totals Coverage Status
Change from base Build 470: 0.04%
Covered Lines: 961
Relevant Lines: 1185

💛 - Coveralls
phahulin commented 6 years ago

I think we should add conditional for clarity.

fvictorio commented 6 years ago

Done. I also fixed the issue with the coverage script.