poanetwork / poa-popa

DApp for proof of physical address (PoPA) attestation for validators of POA Network
https://popa.poa.network
GNU General Public License v3.0
24 stars 18 forks source link

(Fix) Swap ifs in ip calculation #172

Closed phahulin closed 6 years ago

phahulin commented 6 years ago

Before submitting a pull request, please provide the following information:

Closes #165

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 534


Files with Coverage Reduction New Missed Lines %
web-dapp/server-lib/session-stores/redis.js 1 80.39%
web-dapp/server-lib/recalc_price.js 12 18.75%
<!-- Total: 13 -->
Totals Coverage Status
Change from base Build 511: 1.4%
Covered Lines: 1007
Relevant Lines: 1193

💛 - Coveralls
fvictorio commented 6 years ago

I think we should add tests here (see this comment).

@phahulin, if you are busy, we can take care of adding the tests.

phahulin commented 6 years ago

@fvictorio yes, please write tests, thank you :+1:

fvictorio commented 6 years ago

@phahulin Tests added.