(Improvement) proposal (i.e. some existing feature can be improved)
What problem have you encountered (provide steps to reproduce if possible) / What feature are you talking about?
In the current implementation price tag is hard-coded in the UI, it should be set via a config file.
What is expected behaviour / What is proposed feature?
Server already has priceWei option in server-config, we should use it to display price in the UI (but not in wei). It would also be good to add a new option that specifies name of the coin (e.g. priceSymbol: 'POA')
Since UI is handled by react, we can't directly use priceWei from config, maybe we can add this to server-config:
pablofullana
commented
6 years ago
What is it? (leave one option)
(Improvement)proposal (i.e. some existing feature can be improved)What problem have you encountered (provide steps to reproduce if possible) / What feature are you talking about?
In the current implementation price tag is hard-coded in the UI, it should be set via a config file.
priceWeioption in server-config, we should use it to display price in the UI (but not in wei). It would also be good to add a new option that specifies name of the coin (e.g.priceSymbol: 'POA') Since UI is handled by react, we can't directly usepriceWeifrom config, maybe we can add this to server-config:If it doesn't work this way, we'll have to add them to
.envdirectly.0.04e+18to1e+18