coveralls
commented
6 years ago Pull Request Test Coverage Report for Build 538
- 9 of 26 (34.62%) changed or added relevant lines in 4 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-1.05%) to 81.235%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| web-dapp/controllers/notifyRegTx.js | 2 | 6 | 33.33% | ||
| web-dapp/server-lib/get_sha3cc.js | 3 | 16 | 18.75% | ||
| <!-- | Total: | 9 | 26 | 34.62% | --> |
| Totals | |
|---|---|
| Change from base Build 536: | -1.05% |
| Covered Lines: | 1021 |
| Relevant Lines: | 1239 |
phahulin
Closes #168.
When a transaction is notified, check that the confirmation code hash in the transaction data matches the confirmation code in the given session. This avoids an attack where the same transaction is sent with different session keys and causes multiple postcards to be sent when only one payment was done.