poanetwork / poa-popa

DApp for proof of physical address (PoPA) attestation for validators of POA Network
https://popa.poa.network
GNU General Public License v3.0
24 stars 18 forks source link

(Improvement) Improve logging #183

Closed phahulin closed 6 years ago

phahulin commented 6 years ago
  1. On errors, write log both to stdout and stderr, it makes it easier to see time-ordered log in a single file.

  2. In some parts of the code createResponseObject(ok, err) is called passing error messages (string) as a second argument, however when logging, err expected to be an object and error message is expected to be in err.msg. This leads to undefined error messages in logs

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 581


Files with Coverage Reduction New Missed Lines %
web-dapp/src/components/RegisterAddressPage.js 39 69.96%
<!-- Total: 39 -->
Totals Coverage Status
Change from base Build 539: -0.07%
Covered Lines: 1022
Relevant Lines: 1240

💛 - Coveralls