Closed phahulin closed 6 years ago
Sounds good to me.
@phahulin Two things:
package-lock.json
in the blockchain directory modified if the audit was not applied there?In any case, I'm OK with merging this.
@fvictorio
"optional": true
in package-lock, without actually upgrading any versions
(Fix)
Apply results of
npm audit fix
for prod-dependencies in web-dapp folder.I think we should skip
blockchain
folder for now, because a fix there requires update oftruffle
which requies an updated version of solidity compiler which leads to changes in contract code. Since contracts are already deployed with the previous solidity compiler version + truffle is not used in production anyway, we can address these changes after v.1.0 is tagged.