search

poanetwork / poa-popa

DApp for proof of physical address (PoPA) attestation for validators of POA Network
https://popa.poa.network
GNU General Public License v3.0
24 stars 18 forks source link

(Fix) Update DApp loading code considering upcoming Breaking Change in MetaMask #201

Closed unjapones closed 5 years ago

unjapones commented 5 years ago

Closes #200 .

Modify the "MetaMask not found" error page to display a generic error text stating "Wallet not found" + "access to Ethereum account not granted"; i.e something in-between what we had previously and what was done for PoBA in this PR.

popa-eip1102

phahulin commented 5 years ago

@unjapones Although changes seem fine, it worries me that CI fails second time with No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself. Could you look into it?

unjapones commented 5 years ago

@phahulin yup! I'm on it :+1: Will leave the in progress label on this PR until I find what's happening. Will ping you when I have news.

unjapones commented 5 years ago

Not sure what's going on with POAS's builds queue, but the last commit I added seems to fix the build, at least on my fork.

unjapones commented 5 years ago

@phahulin Travis build is green again :sunglasses: