Closed unjapones closed 5 years ago
Just in case, I have just performed the following:
erc-725-integration
from this repo branch since I had it on my clone-repo (that caused the automatic close of the PR, sorry for the spam).@phahulin friendly ping 😬
I think it's best if we stay with two contracts without the need to upgrade existing PoPA contract. I'm gonna merge this into a new branch (not master), so that we can safely upgrade existing setup, because this PR introduces some breaking changes.
Integration branch that includes the code from PRs #208 , #209 + some UI improvements on the ERC-735 claim generation page.
@phahulin one thing that it is still pending:
The reason:
The not so good thing about this is that the address of the "PoPA identity contract" (the address that appears on the
issuer
field of the ERC-735 claims, and that I highlight in the demo below) holds the address ofProofOfPhysicalAddressKeyHolder.sol
and not the mainProofOfPhysicalAddress.sol
. I'm not really sure if this is abad thing but we end up with 2 contracts... [1]@phahulin do you have an opinion on the above? May be we could try a refactor using Solidity's
delegatecall
, or some other pattern, so we end up with a unique contract that has everything: previous features + new identity/key holder features.Short demo:
NOTES:
ProofOfPhysicalAddress.sol
was the compiler version so, in theory, we should not need to upgrade/redeploy it.