(Feature) Add Coverage badge

poanetwork / poa-popa

DApp for proof of physical address (PoPA) attestation for validators of POA Network

https://popa.poa.network

GNU General Public License v3.0

24 stars 18 forks source link

(Feature) Add Coverage badge #29

Closed pablofullana closed 6 years ago

pablofullana commented 6 years ago

What is it? (leave one option)
- New (Feature) request (i.e. some nice-to-have feature is missing)
What problem have you encountered (provide steps to reproduce if possible) / What feature are you talking about? Add a coverage badge to the README file, making it easier to see.
What is expected behaviour / What is proposed feature? Coverage badge in README
Additional information We need to active the repository on [Coveralls]https://coveralls.io/github/poanetwork/poa-popa) and Travis

[x] Coveralls [] Travis

phahulin commented 6 years ago

Should be activated on travis now

igorbarinov commented 6 years ago

@pablofullana please elaborate on coveralls We didn't use it before. what is the purpose of it?

pablofullana commented 6 years ago

@igorbarinov @matiasgaratortiz added the integration with coveralls.io so we have insights on code coverage. This will allow us to rely on our testing suite with more confidence and put special focus on parts of the code that are not fully tested.

igorbarinov commented 6 years ago

I see. @pablofullana Do you need anything from me or Pavel for it?

pablofullana commented 6 years ago

@igorbarinov we are working on this right now. We'll let you guys know if anything is required from your side.