poanetwork / poa-popa

DApp for proof of physical address (PoPA) attestation for validators of POA Network
https://popa.poa.network
GNU General Public License v3.0
24 stars 18 forks source link

(Refactor) Move signature logic to function #41

Closed fvictorio closed 6 years ago

fvictorio commented 6 years ago

The smart contract tests need to build valid values for the secp256k1 signature. To make this easier and DRY, I moved the logic of building the text to sign to a reusable function, and used that in the tests.

This PR also:

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 36


Files with Coverage Reduction New Missed Lines %
server-lib/sign.js 2 0.0%
routes/prepare_reg_tx.js 8 0.0%
<!-- Total: 10 -->
Totals Coverage Status
Change from base Build 25: 0.07%
Covered Lines: 62
Relevant Lines: 739

💛 - Coveralls