search

poanetwork / poa-popa

DApp for proof of physical address (PoPA) attestation for validators of POA Network
https://popa.poa.network
GNU General Public License v3.0
24 stars 18 forks source link

(Test) Merge coverages in coveralls #49

Closed fvictorio closed 6 years ago

fvictorio commented 6 years ago

Depends on #48. Closes #47.

Merge the coverages of the blockchain and web-dapp directories.

Don't merge this yet, I want to check that this PR produces the correct result in coveralls.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 72

Totals Coverage Status
Change from base Build 65: 1.5%
Covered Lines: 213
Relevant Lines: 975
💛 - Coveralls
fvictorio commented 6 years ago

Ok, this works, but it's more of a proof of concept that shows that this approach will work. The smart contract tests don't work in the CI because contract-output.json is not generated, so I need to make a proper fix for that (here I just commented a require and used the globally injected web3, but that of course will break the server).

phahulin commented 6 years ago

@fvictorio Matias added mocked contract-output.json here https://github.com/poanetwork/poa-popa/pull/45 maybe that'll help?

fvictorio commented 6 years ago

@phahulin @matiasgaratortiz This is ready for review now.