Closed garatortiz closed 6 years ago
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
routes/notify_reg_tx.js | 3 | 0.0% | ||
<!-- | Total: | 3 | --> |
Totals | |
---|---|
Change from base Build 65: | 0.02% |
Covered Lines: | 179 |
Relevant Lines: | 878 |
Error is still present
2018-02-26T13:18:47.683Z [request] (ID=hTzs02) POST /notifyRegTx by {"host":"localhost:3000","connection":"keep-alive","content-length":"153","accept":"*/*","origin":"http://localhost:3000","x-requested-with":"XMLHttpRequest","user-agent":"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.186 Safari/537.36","content-type":"application/x-www-form-urlencoded; charset=UTF-8","dnt":"1","referer":"http://localhost:3000/","accept-encoding":"gzip, deflate, br","accept-language":"en-US,en;q=0.9,ru;q=0.8"}
2018-02-26T13:18:47.684Z [notifyRegTx] (ID=hTzs02) fetching info by session_key: 0.4619839593798434
2018-02-26T13:18:47.685Z [notifyRegTx] (ID=hTzs02) fetching tx_details from blockchain by tx_id: 0xb02137d57736dd5acdf14524e42b44fefa971d536f62e436b68f47b2f026096e
2018-02-26T13:18:47.701Z [notifyRegTx] (ID=hTzs02) undefined
2018-02-26T13:18:47.701Z [response] (ID=hTzs02) {"ok":false,"x_id":"hTzs02"}
I can't reproduce that error
2018-02-26T15:07:14.859Z [request] (ID=ih4d44) POST /notifyRegTx by {"host":"localhost:3000","connection":"keep-alive","content-length":"154","accept":"*/*","origin":"http://localhost:3000","x-requested-with":"XMLHttpRequest","user-agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.167 Safari/537.36","content-type":"application/x-www-form-urlencoded; charset=UTF-8","referer":"http://localhost:3000/","accept-encoding":"gzip, deflate, br","accept-language":"en-US,en;q=0.9,es;q=0.8","cookie":"_ga=GA1.1.697460844.1510944979; pnctest=1; Webstorm-acdb6c4f=60d3cddb-b740-4349-8725-a510ae4b4aef"}
2018-02-26T15:07:14.863Z [notifyRegTx] (ID=ih4d44) fetching info by session_key: 0.47361685207472903
2018-02-26T15:07:14.864Z [notifyRegTx] (ID=ih4d44) fetching tx_details from blockchain by tx_id: 0xec80a7e0d833b788d04e03f41ffb038225efeb8d942197f291789cac34a7e756
2018-02-26T15:07:14.876Z [notifyRegTx] (ID=ih4d44) got block number for tx_id: 0xec80a7e0d833b788d04e03f41ffb038225efeb8d942197f291789cac34a7e756, tx_bn: 2
2018-02-26T15:07:14.911Z [notifyRegTx] (ID=ih4d44) getting address details from contract
2018-02-26T15:07:15.015Z [notifyRegTx] (ID=ih4d44) full address: {"country":"us","state":"ca","city":"beverly hills","location":"123, main st.","zip":"90210","name":"john doe"}
2018-02-26T15:07:16.651Z [notifyRegTx] (ID=ih4d44) postcard: {"id":"psc_a941413f298df481","description":"Postcard for 0x1aa2d288d03d8397c193d2327ee7a7443d4ec3a1","metadata":{"wallet":"0x1aa2d288d03d8397c193d2327ee7a7443d4ec3a1","tx_id":"0xec80a7e0d833b788d04e03f41ffb038225efeb8d942197f291789cac34a7e756","generation_time":"2018-02-26T15:07:15.015Z"},"to":{"id":"adr_6b8ae1a71eb0a9f2","description":null,"name":"JOHN DOE","company":null,"phone":null,"email":null,"address_line1":"123, MAIN ST.","address_line2":null,"address_city":"BEVERLY HILLS","address_state":"CA","address_zip":"90210","address_country":"UNITED STATES","metadata":{},"date_created":"2018-02-26T15:07:16.418Z","date_modified":"2018-02-26T15:07:16.418Z","deleted":true,"object":"address"},"from":null,"url":"https://s3.us-west-2.amazonaws.com/assets.lob.com/psc_a941413f298df481.pdf?AWSAccessKeyId=AKIAIILJUBJGGIBQDPQQ&Expires=1522249636&Signature=vIULRpZxZrjUW87fPuFuYqzwM20%3D","front_template_id":null,"back_template_id":null,"front_template_version_id":null,"back_template_version_id":null,"carrier":"USPS","tracking_events":[],"thumbnails":[{"small":"https://s3.us-west-2.amazonaws.com/assets.lob.com/psc_a941413f298df481_thumb_small_1.png?AWSAccessKeyId=AKIAIILJUBJGGIBQDPQQ&Expires=1522249636&Signature=lddOgK5M7ofbDmjBOigcLYNwXIo%3D","medium":"https://s3.us-west-2.amazonaws.com/assets.lob.com/psc_a941413f298df481_thumb_medium_1.png?AWSAccessKeyId=AKIAIILJUBJGGIBQDPQQ&Expires=1522249636&Signature=m6RwwHU%2Bjg57zWbUsb8sOOtqE0Y%3D","large":"https://s3.us-west-2.amazonaws.com/assets.lob.com/psc_a941413f298df481_thumb_large_1.png?AWSAccessKeyId=AKIAIILJUBJGGIBQDPQQ&Expires=1522249636&Signature=LhFnlC46eDuykYDNqaF8AtIKhbo%3D"},{"small":"https://s3.us-west-2.amazonaws.com/assets.lob.com/psc_a941413f298df481_thumb_small_2.png?AWSAccessKeyId=AKIAIILJUBJGGIBQDPQQ&Expires=1522249636&Signature=WhUnmsIhy1ng9JlWtR3kT7igpYM%3D","medium":"https://s3.us-west-2.amazonaws.com/assets.lob.com/psc_a941413f298df481_thumb_medium_2.png?AWSAccessKeyId=AKIAIILJUBJGGIBQDPQQ&Expires=1522249636&Signature=MclSP%2BAboGZ6MBzj7bT2jG4AUVU%3D","large":"https://s3.us-west-2.amazonaws.com/assets.lob.com/psc_a941413f298df481_thumb_large_2.png?AWSAccessKeyId=AKIAIILJUBJGGIBQDPQQ&Expires=1522249636&Signature=BR4xMe%2F2YxtsGoMmDRlHGmSGhJE%3D"}],"size":"4x6","mail_type":"usps_first_class","expected_delivery_date":"2018-03-05","date_created":"2018-02-26T15:07:16.473Z","date_modified":"2018-02-26T15:07:16.473Z","send_date":"2018-02-26T15:12:16.470Z","object":"postcard"}
2018-02-26T15:07:16.651Z [notifyRegTx] (ID=ih4d44) removing used session_key from memory: 0.47361685207472903
2018-02-26T15:07:16.651Z [response] (ID=ih4d44) {"ok":true,"result":{"mail_type":"usps_first_class","expected_delivery_date":"2018-03-05"},"x_id":"ih4d44"}
Yes, something was wrong on my side
Before submitting a pull request, please provide the following information:
What is it? (leave one option)
(Fix)
What was the root cause of the problem originally / what feature was missing? When address info is filled, transaction is mined, but postcard is not sent because an error occurs in notify_reg_tx route.
How does this pull request solve it (in broad terms)? Fixes the names of the methods that are called in the workflow.
Does it close any open issues? Closes #51
Quick checklist
Additional information