Closed garatortiz closed 6 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
web-dapp/server-lib/post_api.js | 0 | 5 | 0.0% | ||
web-dapp/controllers/prepareRegTx.js | 54 | 64 | 84.38% | ||
web-dapp/routes/prepare_reg_tx.js | 0 | 24 | 0.0% | ||
<!-- | Total: | 54 | 93 | 58.06% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
web-dapp/routes/prepare_reg_tx.js | 1 | 0.0% | ||
<!-- | Total: | 1 | --> |
Totals | |
---|---|
Change from base Build 102: | 7.02% |
Covered Lines: | 325 |
Relevant Lines: | 997 |
hurray, travis passed at last:)
What is it? (leave one option)
(Refactor)
of existing code (no functionality change)What was the root cause of the problem originally / what feature was missing? The original code of the
prepare_reg_tx
was not very testable and maintainable.How does this pull request solve it (in broad terms)? Simplify code in order to make it more readable and testable by mainly extracting and refactoring functions.
Does it close any open issues? Closes #19
Quick checklist
Additional information This PR also adds the prepareRegTx controller tests