Closed phahulin closed 6 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
web-dapp/controllers/notifyRegTx.js | 6 | 7 | 85.71% | ||
web-dapp/src/components/ConfirmationPage.js | 0 | 1 | 0.0% | ||
web-dapp/src/components/RegisterAddressPage.js | 0 | 1 | 0.0% | ||
web-dapp/server-lib/validate_tx_receipt.js | 7 | 9 | 77.78% | ||
web-dapp/server-lib/get_tx_receipt.js | 0 | 5 | 0.0% | ||
<!-- | Total: | 13 | 23 | 56.52% | --> |
Totals | |
---|---|
Change from base Build 142: | 0.8% |
Covered Lines: | 385 |
Relevant Lines: | 1043 |
What is it? (leave one option)
(Fix)
What was the root cause of the problem originally / what feature was missing?
notifyRegTx
was not checking for status of mined tx, so it could accept tx that was mined but failedHow does this pull request solve it (in broad terms)? Add call to
web3.getTransactionReceipt()
to check status field. Also add test for thisDoes it close any open issues? Closes #69
Quick checklist