Closed phahulin closed 6 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
web-dapp/controllers/notifyRegTx.js | 7 | 8 | 87.5% | ||
web-dapp/src/components/ConfirmationPage.js | 0 | 1 | 0.0% | ||
web-dapp/src/components/RegisterAddressPage.js | 0 | 1 | 0.0% | ||
web-dapp/server-lib/validate_tx_receipt.js | 7 | 9 | 77.78% | ||
web-dapp/routes/notify_reg_tx.js | 0 | 2 | 0.0% | ||
web-dapp/server-lib/get_tx_receipt.js | 0 | 5 | 0.0% | ||
<!-- | Total: | 14 | 26 | 53.85% | --> |
Totals | |
---|---|
Change from base Build 142: | 0.7% |
Covered Lines: | 384 |
Relevant Lines: | 1043 |
What is it? (leave one option)
(Fix)
What was the root cause of the problem originally / what feature was missing? Time when server starts tracking tx was set in the function that's polling data from blockchain
If transaction is not mined yet, this function is called again, thus resetting
startAt
, so condition to stop polling may never betrue
How does this pull request solve it (in broad terms)? Set
startAt
in the caller, before invokinggetTxBlockNumber
, pass it as parameter.Does it close any open issues? Closes #71
Quick checklist