Closed garatortiz closed 6 years ago
contract-output.json is specific to particular deployment, so it should probably be out of version control (if that's possible), or at least be empty {}
Totals | |
---|---|
Change from base Build 170: | 10.2% |
Covered Lines: | 763 |
Relevant Lines: | 1077 |
Could you do the same hocus-pocus as server-config-private.js
with contract-output.json
?
i.e. put some test version of the file in web-dapp/test/server/_utils/
add cp ...
to before_script
in travis.yml and then remove contract-output.json
from repository? Also fix its path in .gitignore
(now it's missing web-dapp/src/
)
What is it? (leave one option)
(Improvement)
of existing functionalityWhat was the root cause of the problem originally / what feature was missing? The 3 files of the routes were refactored but do not have any tests to provide coverage.
How does this pull request solve it (in broad terms)? Adds tests + coverage.
Does it close any open issues? Closes #74
Quick checklist
Additional information