poanetwork / poa-popa

DApp for proof of physical address (PoPA) attestation for validators of POA Network
https://popa.poa.network
GNU General Public License v3.0
24 stars 18 forks source link

(Improvement) Add tests to API's routes #80

Closed garatortiz closed 6 years ago

garatortiz commented 6 years ago
phahulin commented 6 years ago

contract-output.json is specific to particular deployment, so it should probably be out of version control (if that's possible), or at least be empty {}

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 217


Totals Coverage Status
Change from base Build 170: 10.2%
Covered Lines: 763
Relevant Lines: 1077

💛 - Coveralls
phahulin commented 6 years ago

Could you do the same hocus-pocus as server-config-private.js with contract-output.json? i.e. put some test version of the file in web-dapp/test/server/_utils/ add cp ... to before_script in travis.yml and then remove contract-output.json from repository? Also fix its path in .gitignore (now it's missing web-dapp/src/)