search

poanetwork / poa-popa

DApp for proof of physical address (PoPA) attestation for validators of POA Network
https://popa.poa.network
GNU General Public License v3.0
24 stars 18 forks source link

(Feature) Remove Address functionality. #87

Closed Janther closed 6 years ago

Janther commented 6 years ago

We'll need to add a function to remove an address. On PoPA-side it should also trigger registry, and registry should trigger PoPA in case subject is removing his own address (since this is allowed by ERC780).

This Issue is a to follow up this thread https://github.com/poanetwork/poa-popa/issues/85#issuecomment-374538722

here is the conversation so far:

@pablofullana @fvictorio:

Right, we need to consider the removal of an address, which may be triggered from both parties. We could discuss removals on it's own thread since it may be not that trivial.

@Janther:

Removal of address is a big thing specially since the legislation of the EU gives everybody the right to be digitally "forgotten". Also, the PoPA dapp should be concerned with confirming addresses so I don't see why would we want triggers for somebody removing their address. That can be done easily though since the registry emits an event with the removal of a claim.

fvictorio commented 6 years ago

We discussed how to implement this feature to allow users to remove their registered addresses. We propose splitting this feature in stages.

  1. Create a page where the user can see the list of physical addresses that they registered, and indicate which ones were already confirmed. This can be done without modifications to the smart contracts.

  2. Modify the PoPA contract, adding a method that allows the user to remove an address that they registered. This method should also remove the claim from the ClaimsRegistry.

  3. Add a "Remove" button next to each item in the list. This button should call the method implemented in the previous step.

  4. (Optional) We should allow "admins" to also be able to remove addresses. This would need some further design, in case it's a desired feature: who can do this? How do they get a list of addresses? Should they be able to see all registered addresses? How do we accomplish this (since mappings cannot be iterated)?

Let us know what you think.

phahulin commented 6 years ago

I think (4) is not necessary.

phahulin commented 6 years ago

I agree on 1-3

fvictorio commented 6 years ago

I think we can close this now.

phahulin commented 6 years ago

Implemented in https://github.com/poanetwork/poa-popa/pull/100 , https://github.com/poanetwork/poa-popa/pull/101