search

poanetwork / poa-popa

DApp for proof of physical address (PoPA) attestation for validators of POA Network
https://popa.poa.network
GNU General Public License v3.0
24 stars 18 forks source link

(Feature) Re-confirmations #88

Open Janther opened 6 years ago

Janther commented 6 years ago

We should also take care about reconfirmations, maybe use one of those 24 extra bytes we have in values to set/remove a flag (1 byte) - address is confirmed/being reconfirmed

This Issue is a to follow up this thread https://github.com/poanetwork/poa-popa/issues/85#issuecomment-374538722

here is the conversation so far:

@pablofullana @fvictorio:

Agreed. Re-confirmations has to be added to the pipeline as well. But I think we should discuss re-confirmations on it's own issue once created.

@Janther:

Since anybody can make Claims, a 3rd party can simply make a claim about a User's Physical Address needing a reconfirmation. Then to see if a Physical Address is confirmed, the dapp only needs to check the registry if the address has a Claim for that address and then check if any of the registered 3rd parties has requested a reconfirmation.

Janther commented 6 years ago

We need to understand now that everything that has been confirmed or re-confirmed will go to the ERC780 registry, so theconfirmation_block probably should go in the registry and removed from the struct PhysicalAddress

Janther commented 6 years ago

Also, I'll close #83 and we can carry on that discussion here.

fvictorio commented 6 years ago

@phahulin Can we close this? As far as I know we are not going to implement it.

phahulin commented 6 years ago

Let's keep it, as a reference for future versions of PoPA