coveralls
commented
6 years ago Pull Request Test Coverage Report for Build 236
- 45 of 96 (46.88%) changed or added relevant lines in 11 files are covered.
- 1 unchanged line in 1 file lost coverage.
- Overall coverage decreased (-0.07%) to 68.504%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| web-dapp/server-lib/recalc_price.js | 0 | 3 | 0.0% | ||
| web-dapp/src/components/ConfirmationPage.js | 10 | 18 | 55.56% | ||
| web-dapp/src/components/RegisterAddressPage.js | 8 | 17 | 47.06% | ||
| blockchain/contracts/ProofOfPhysicalAddress.sol | 13 | 44 | 29.55% | ||
| <!-- | Total: | 45 | 96 | 46.88% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| blockchain/contracts/ProofOfPhysicalAddress.sol | 1 | 33.57% | ||
| <!-- | Total: | 1 | --> |
| Totals | |
|---|---|
| Change from base Build 230: | -0.07% |
| Covered Lines: | 759 |
| Relevant Lines: | 1060 |
What is it? (leave one option)
(Fix)(Refactor)of existing code (no functionality change)What was the root cause of the problem originally / what feature was missing? Both contracts have many faults to the rules of the Solhint standard
How does this pull request solve it (in broad terms)? Apply Solhint rules.
Does it close any open issues? Closes #3
Quick checklist
Additional information