coveralls
commented
6 years ago Pull Request Test Coverage Report for Build 239
- 96 of 155 (61.94%) changed or added relevant lines in 26 files are covered.
- 2 unchanged lines in 2 files lost coverage.
- Overall coverage decreased (-0.07%) to 68.504%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| web-dapp/server-lib/session-stores/redis.js | 0 | 1 | 0.0% | ||
| web-dapp/server-lib/get_tx_receipt.js | 1 | 2 | 50.0% | ||
| web-dapp/server-lib/validate_tx_receipt.js | 1 | 3 | 33.33% | ||
| web-dapp/src/components/RegisterAddressPage.js | 5 | 7 | 71.43% | ||
| web-dapp/controllers/prepareRegTx.js | 0 | 2 | 0.0% | ||
| web-dapp/routes/_lists.js | 0 | 5 | 0.0% | ||
| web-dapp/controllers/notifyRegTx.js | 20 | 28 | 71.43% | ||
| web-dapp/src/components/ConfirmationPage.js | 12 | 23 | 52.17% | ||
| web-dapp/routes/notify_reg_tx.js | 1 | 14 | 7.14% | ||
| web-dapp/server-lib/recalc_price.js | 3 | 17 | 17.65% | ||
| <!-- | Total: | 96 | 155 | 61.94% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| web-dapp/controllers/prepareRegTx.js | 1 | 91.78% | ||
| web-dapp/server-lib/recalc_price.js | 1 | 20.45% | ||
| <!-- | Total: | 2 | --> |
| Totals | |
|---|---|
| Change from base Build 237: | -0.07% |
| Covered Lines: | 759 |
| Relevant Lines: | 1060 |
What is it? (leave one option)
(Refactor)of existing code (no functionality change)What was the root cause of the problem originally / what feature was missing? Throughout the project you could find a lot of variables named using snake_case
How does this pull request solve it (in broad terms)? Change snake_case to camelCase
Does it close any open issues? Closes #82
Quick checklist
Additional information