Closed Janther closed 6 years ago
@Janther Please, can you review the TravisCI error? It's related to test and coverage for smart contracts.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
blockchain/contracts/PhysicalAddressClaim.sol | 0 | 8 | 0.0% | ||
blockchain/contracts/ProofOfPhysicalAddress.sol | 1 | 14 | 7.14% | ||
<!-- | Total: | 9 | 30 | 30.0% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
blockchain/contracts/ProofOfPhysicalAddress.sol | 14 | 31.54% | ||
<!-- | Total: | 14 | --> |
Totals | |
---|---|
Change from base Build 258: | -0.9% |
Covered Lines: | 799 |
Relevant Lines: | 1046 |
What is it? (leave one option)
(Feature)
implementationWhat feature was missing? Use of an ERC780 registry to store claims about a given address.
How does this pull request solve it (in broad terms)? I added a library that codes and decodes a
uint256
not greater than 8 bytes and a version number of 1 byte into abytes32
variable.In
ProofOfPhysicalAddress.sol
I changed theconfirmAddress
anduserAddressConfirmed
to use the library to code and decode information and store it in an ERC780 registry.Does it close any open issues? Addresses #85 but not necessarily closes it.
Quick checklist
Additional information