poanetwork / poa-popa

DApp for proof of physical address (PoPA) attestation for validators of POA Network
https://popa.poa.network
GNU General Public License v3.0
24 stars 18 forks source link

(Feature) adding erc780 and library for coding and encoding data #93

Closed Janther closed 6 years ago

Janther commented 6 years ago

In ProofOfPhysicalAddress.sol I changed the confirmAddress and userAddressConfirmed to use the library to code and decode information and store it in an ERC780 registry.

garatortiz commented 6 years ago

@Janther Please, can you review the TravisCI error? It's related to test and coverage for smart contracts.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 260


Changes Missing Coverage Covered Lines Changed/Added Lines %
blockchain/contracts/PhysicalAddressClaim.sol 0 8 0.0%
blockchain/contracts/ProofOfPhysicalAddress.sol 1 14 7.14%
<!-- Total: 9 30 30.0% -->
Files with Coverage Reduction New Missed Lines %
blockchain/contracts/ProofOfPhysicalAddress.sol 14 31.54%
<!-- Total: 14 -->
Totals Coverage Status
Change from base Build 258: -0.9%
Covered Lines: 799
Relevant Lines: 1046

💛 - Coveralls