Closed phahulin closed 6 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
blockchain/contracts/ProofOfPhysicalAddress.sol | 0 | 11 | 0.0% | ||
<!-- | Total: | 0 | 11 | 0.0% | --> |
Totals | |
---|---|
Change from base Build 280: | -0.8% |
Covered Lines: | 799 |
Relevant Lines: | 1057 |
What is it? (leave one option)
(Fix)
What was the root cause of the problem originally / what feature was missing? Functions
userAddressesCount
anduserLastUserName
counted allphysicalAddresses
, both confirmed and not confirmed, which might lead to confusion.How does this pull request solve it (in broad terms)? Split each of these functions in two variants, e.g.
userLastSubmittedName
anduserLastConfirmedName
to clearly distinguish between the two. Also updatecontract-output.json
file used for testsDoes it close any open issues? Closes #78
Quick checklist
npm run lint
shows no errors