search

poanetwork / threshold_crypto

A pairing-based threshold cryptosystem for collaborative decryption and signatures used in HoneybadgerBFT implementation
Other
191 stars 72 forks source link

Add additional benchmarks #33

Closed fhaynes closed 6 years ago

fhaynes commented 6 years ago

Here's a few additional benchmarks. I put in a Makefile to make running tests/benches a bit easier, but I can do that in a separate commit if you want (or remove it). I ran rustfmt per the contributing guide, but it decided several more files needed reformatting. =) Would you prefer that in a separate commit?

c0gent commented 6 years ago

It looks like you're using a different version of rustfmt. Try setting your rust toolchain to stable and do a rustup update. You may need to revert the existing formatting changes first to get it to match back up.

You'll also want to squash those commits. We generally try to keep it to one commit per PR unless there is a good reason to separate things (formatting would be a good example of this).

fhaynes commented 6 years ago

Yeah, just discovered I'm a bit behind on rustfmt. I updated and ran the check that failed in travis, and it passed this time. I'll squash in the meantime.

fhaynes commented 6 years ago

Yay, that looks better, I think.

c0gent commented 6 years ago

Just a heads up, we'll probably wait for @afck to review this. He probably won't be able to until next week.

DrPeterVanNostrand commented 6 years ago

@fhaynes Thanks for adding these benchmarks!

fhaynes commented 6 years ago

After a lot of dramatic fighting with git rebase, the bivar test should be cleaned out. =)

fhaynes commented 6 years ago

I'm not sure why, but the build is failing at this point:

$ cargo test --all-features --release
   Compiling threshold_crypto v0.1.0 (file:///home/travis/build/poanetwork/threshold_crypto)
error: Could not compile `threshold_crypto`.
warning: build failed, waiting for other jobs to finish...
error: Could not compile `threshold_crypto`.
To learn more, run the command again with --verbose.
The command "cargo test --all-features --release" exited with 101.

Interestingly, if I add --verbose to the travis config, it builds fine. Am I missing something obvious here?

fhaynes commented 6 years ago

And that same command works fine locally

DrPeterVanNostrand commented 6 years ago

If your PR fails due to cargo fmt Travis will cache that build and run the cached version if you push a minor update to your PR (i.e. push code that doesn't affect the binary). I cleared the cache for your PR and rebuilt it, hopefully that works.

14 minutes later...

Alright, it builds now.

fhaynes commented 6 years ago

Cool, I resolved the remaining conversations.