(Bug) Contribution confirmation popup

poanetwork / token-wizard

(Discontinued) TokenWizard is an DApp to create and manage crowdsale and token contracts using a simple UI

MIT License

384 stars 215 forks source link

(Bug) Contribution confirmation popup #1053

Closed mariano-aguero closed 6 years ago

mariano-aguero commented 6 years ago

Closes #986

Added function to get user token balance
Check token balance before and after purchase

BlackDuckCoPilot commented 6 years ago

Black Duck Security Report

Merging #1053 into 2.0 will not change security risk.

Added Components

Clean: 3

Click here to see full report

dennis00010011b commented 6 years ago

@mariano-aguero Minted crowdsale: amount of purchase always 0 in popup Steps:

Create Minted, 1 tier, no whitelist 2 Buy some valid amount
Observe popup after purchase

dennis00010011b commented 6 years ago

@mariano-aguero I faced with same issue for Minted crowdsale.

mariano-aguero commented 6 years ago

I was testing by an hour the problem suggested by @dennis00010011b . Minted and dutch strategy several times, I think it's like a heisenbug. I will continue testing later. The video of one test https://www.useloom.com/share/0437a78e2dc14e66adadca8f7e0b8dac

dennis00010011b commented 6 years ago

@mariano-aguero Testing with ganache https://www.useloom.com/share/55485b26d6144ea5902e4b039057fe82

mariano-aguero commented 6 years ago

@dennis00010011b I was able to reproduce the error in my local computer using ganache. I add a functionality to perform a retry until the balance is modified in the case of the success of the transaction. Can you try to test the both strategies again? Thanks in advance

dennis00010011b commented 6 years ago

@mariano-aguero @vbaranov Tested it . No issues were found