(Fix) Replace getCurrentTierInfo with getCrowdsaleTier for minted capped strategy

poanetwork / token-wizard

(Discontinued) TokenWizard is an DApp to create and manage crowdsale and token contracts using a simple UI

MIT License

384 stars 215 forks source link

(Fix) Replace getCurrentTierInfo with getCrowdsaleTier for minted capped strategy #1058

Closed mariano-aguero closed 6 years ago

mariano-aguero commented 6 years ago

Closes #1012

Added function getCurrentTierInfoCustom to replace actual getCurrentTierInfo
A refactoring was performed in the contribute and manage sections

BlackDuckCoPilot commented 6 years ago

Black Duck Security Report

Branch 2.0 has no Black Duck results, and could not be compared to #1058. Analyze branch 2.0 to get a change comparison.

Removed Components

Medium Risk: 40 Clean: 3911

Click here to see full report

BlackDuckCoPilot commented 6 years ago

Black Duck Security Report

Merging #1058 into 2.0 will not change security risk.

Click here to see full report

mariano-aguero commented 6 years ago

Hi @dennis00010011b , I was able to corroborate the test case with ganache successfully. I make some modifications in the function that returns the tier to solve the problem, could you check it? Thank you

dennis00010011b commented 6 years ago

@mariano-aguero Tested with ganache Minted:1 tier, no whitelist, decimals=18, rate=1000, supply=200, minCap=13, duration 4 min:

Crowdsale page: incorrect rate value
Contribution page: incorrect minContribution value (0.00416 instead 13)
Contribution page: incorrect maxContribution value (13 instead 200)
- Investor can't buy, all transaction failed

dennis00010011b commented 6 years ago

@mariano-aguero Tested with ganache Minted:1 tier, no whitelist, decimals=18, rate=1000, supply=200, minCap=13, any duration:

Investor can't buy, all transaction failed despite maximum gas limit and gas price in metamask
Error message in console

localhost-1532507393317.log

dennis00010011b commented 6 years ago

@mariano-aguero Tested with ganache Dutch: no whitelist, decimals=18, totalSupply=1000, supply=1000 , minRate=100, maxRate=200, minCap=13, duration by default:

Contribution page: incorrect minContribution value (1e-18 instead 13)

mariano-aguero commented 6 years ago

The object returned by the getCurrentTierInfo method is different from the object returned by the method getCrowdsaleTier, so I had to generate an object that maintains the original properties of the tier.
Conflicts resolved by pulling branch 2.0 changes

@dennis00010011b can you check it? Thanks

mariano-aguero commented 6 years ago

@dennis00010011b I think this branch issue#1012 closes #1055 Can you checked? If is OK, if we merge this PR we can closes #1055

dennis00010011b commented 6 years ago

@mariano-aguero Right, https://github.com/poanetwork/token-wizard/issues/1055 isn't reproducible in branch issue#1012

vbaranov commented 6 years ago

@mariano-aguero I think we need to wait for @fernandomg voice for this PR, as he was starting working on this issue before.

mariano-aguero commented 6 years ago

@vbaranov Ok, he is currently on vacation, we will have to wait until next week