search

poanetwork / token-wizard

(Discontinued) TokenWizard is an DApp to create and manage crowdsale and token contracts using a simple UI
MIT License
384 stars 215 forks source link

(Bug) Reserved addresses are not initialized if list length > 20 #1064

Closed mariano-aguero closed 6 years ago

mariano-aguero commented 6 years ago

Closes #1048

There is a limitation based on the contracts, see image screenshot_20180726_141508

When you upload a file that exceeds 20 addresses, a message like this should appear, see image screenshot_20180726_161613

BlackDuckCoPilot commented 6 years ago

Black Duck Security Report

Merging #1064 into 2.0 will not change security risk.

Click here to see full report

mariano-aguero commented 6 years ago

@vbaranov Currently has a validator, which validates when a user adds an address individually, or when a user uploads a CSV file (both actions). It will warning the user with a message, and will list the first 20 addresses added. Do you agree with that? Any modification in this process? Maybe you prefer not validate when adding addresses, list all the addresses added (even if they are more than 20), and at the moment of pressing the 'Continue' button, validate in that action. Can you confirm this? Thanks for the feedback

vbaranov commented 6 years ago

Currently has a validator, which validates when a user adds an address individually, or when a user uploads a CSV file (both actions). It will warning the user with a message, and will list the first 20 addresses added. Do you agree with that? Any modification in this process?

Yes. I agree. This is what I meant. There is no need to change it. @mariano-aguero could you resolve merging conflicts?

mariano-aguero commented 6 years ago

@vbaranov Great, conflict solved!

dennis00010011b commented 6 years ago

@mariano-aguero Build failed to compile . Error message in console:

Failed to compile.

./src/utils/constants.js
  Line 298:  Delete `⏎`  prettier/prettier

Search for the keywords to learn more about each error.
mariano-aguero commented 6 years ago

@dennis00010011b There was an enter character left, remove it

dennis00010011b commented 6 years ago

@vbaranov @mariano-aguero Tested it .No issues were found