(Bug) Minted, Dutch: Whitelisted addresses are not initialized if list length > 60

poanetwork / token-wizard

(Discontinued) TokenWizard is an DApp to create and manage crowdsale and token contracts using a simple UI

MIT License

384 stars 215 forks source link

(Bug) Minted, Dutch: Whitelisted addresses are not initialized if list length > 60 #1065

Closed mariano-aguero closed 6 years ago

mariano-aguero commented 6 years ago

Closes #1052

The problem is also reproducible with values lower than 60, and it is random sometimes 59, sometimes 58, sometimes 60. I take the decision to put a limit of 50

Add constant to limit whitelisted addresses to 50
Add two new alerts for whitelisted addresses, when the validation is applied
Refactor processWhitelist function
Add function to validate whitelisted addresses length
Apply whitelist validation to the component

BlackDuckCoPilot commented 6 years ago

Black Duck Security Report

Merging #1065 into 2.0 will not change security risk.

Click here to see full report

BlackDuckCoPilot commented 6 years ago

Black Duck Security Report

Merging #1065 into 2.0 will not change security risk.

Click here to see full report

dennis00010011b commented 6 years ago

@mariano-aguero Minted-Contribution page: Incorrect maxCap for whitelisted investors Ropsten, proxyID 0xce4c704c3af8f359929ed09d3fe3739913d5e263 Steps:

Create Minted crowdsale, 1 tier, duration by default, decimals=18, rate=1000, supply=100
In Step 3 add whitelisted addresses from file : https://drive.google.com/open?id=1jGWohlqK3PttrPHT_Sma1ousATHSm0gz Private keys: https://drive.google.com/open?id=1QB8Y6qm11ZBRbPd9kiRF7ccd1_ALBJPN
1. Finish deployment
2. Set in wallet any whitelisted account
3. Open contribution file, observe max contibution, try to buy Actual result:
  - whitelisted address can't buy
  - incorrect value of max contribution

dennis00010011b commented 6 years ago

Issue is filed https://github.com/poanetwork/token-wizard/issues/1067