(Bug) Keep data between the steps (Step 1)

poanetwork / token-wizard

(Discontinued) TokenWizard is an DApp to create and manage crowdsale and token contracts using a simple UI

MIT License

384 stars 215 forks source link

(Bug) Keep data between the steps (Step 1) #1070

Closed mariano-aguero closed 6 years ago

mariano-aguero commented 6 years ago

This is an integration PR for the step 1. How to test it and what to test:

Go to the home
Create a crowdsale
In the first step, press button "New crowdsale"
Select the type of strategy
Go to the second step
Go back to step 1
Should keep the selected strategy
Refresh the step 1 page
Should keep the selected strategy
Go to the home, and press button "New crowdsale"
The selected strategy must be the default, "WHITELIST WITH CAP"

The branch 2.0-integration must not be closed Next steps to integrate:

BlackDuckCoPilot commented 6 years ago

Black Duck Security Report

Merging #1070 into 2.0-steps-integration will not change security risk.

Click here to see full report

dennis00010011b commented 6 years ago

@mariano-aguero Minted-Manage page: 1 extra tier is rendered after each refreshing of page Steps:

Create Minted crowdsale with 1 tier, any parameters
As an owner open manage page.
Refresh page, observe number of tiers

mariano-aguero commented 6 years ago

Hi @dennis00010011b Changes are added to an integrating branch. I did this, so we can focus on step-by-step issues that may arise. Then, when all steps are tested/approved, we should make a full test before merging to 2.0 branch. For that particular issue you're mentioning, it gets duplicated because in the Contribute page the app is pushing tier data on every refresh, instead of cleaning it up. I'll be working on that particular step in the next days.

Cheers

mariano-aguero commented 6 years ago

@fernandomg Fix applied and suggested refactoring

dennis00010011b commented 6 years ago

Tested it . No issues were found

mariano-aguero commented 6 years ago

Updated with changes from branch 2.0

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 2864

43 of 89 (48.31%) changed or added relevant lines in 13 files are covered.
7 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.1%) to 20.519%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/stores/ReservedTokenStore.js	0	1	0.0%
src/utils/blockchainHelpers.js	0	1	0.0%
src/App.js	0	2	0.0%
src/utils/utils.js	0	4	0.0%
src/components/Common/ButtonContinue.js	0	10	0.0%
src/components/Home/index.js	0	14	0.0%
src/components/stepOne/index.js	0	14	0.0%
<!--	Total:	43	89	48.31%	-->

Files with Coverage Reduction	New Missed Lines	%
src/App.js	1	0.0%
src/components/stepOne/index.js	3	0.0%
src/components/Home/index.js	3	0.0%
<!--	Total:	7	-->

Totals
Change from base Build 2862:	0.1%
Covered Lines:	864
Relevant Lines:	3612

💛 - Coveralls

vbaranov commented 6 years ago

@mariano-aguero please get upstream from 2.0 branch

mariano-aguero commented 6 years ago

@vbaranov

please get upstream from 2.0 branch

Updated

vbaranov commented 6 years ago

@dennis00010011b Some e2e tests failed in CI. Is the problem with the tests itself, or the failures are caused by the changes from this PR?

dennis00010011b commented 6 years ago

@vbaranov @mariano-aguero Tests are good. There is problem with manage page: tier is rendered twice

https://github.com/poanetwork/token-wizard/pull/1070#issuecomment-410744644

mariano-aguero commented 6 years ago

Hi @dennis00010011b I'm working in the manage section in another PR. I still have to push the changes