Closed fernandomg closed 6 years ago
@fernandomg Manage page: allowed to add whitelisted investors with maxCap greater than remained token's supply. Steps:
Expected result:
Actual result:
@dennis00010011b that was quick! thanks for the catch, will review it
Merging #1072 into 2.0 will not change security risk.
Clean: 2
Ok, so after reviewing the different scenarios that will arise with this PR and have a chat with @vbaranov. It was decided to close this PR and create a new solution for #1067, which is https://github.com/poanetwork/token-wizard/issues/1067#issuecomment-411397561
Closes #1067
This PR fixes all the related issues with whitelisted addresses and tier's supply. Scenarios that I took into account for both strategies (MintedCapped and DutchAuction):
maxCap
of[100, 200, 300]
ifsupply
is400
, then only the first two addresses will be added.supply
value will be validated against the sum of themaxCap
s. It should not be less than themaxCap
sum.manage
screensupply
cannot be edited, so whitelist addresses will be checked.Note The scenario that I didn't fix, due to the complexity of the fix itself (it would require several modifications and would be better to address it in a separate PR), has to be with
manage
screen and an address values modification.As you can see in the screenshot Despite having
1011
tokens available, and requiring only28
extra tokens to change1972
to2000
, it's giving the error as it considers that the address is new and not a modification of an existing one.Also: