search

poanetwork / token-wizard

(Discontinued) TokenWizard is an DApp to create and manage crowdsale and token contracts using a simple UI
MIT License
384 stars 215 forks source link

(Fix) Investors incorrect maxCap #1073

Closed fernandomg closed 6 years ago

fernandomg commented 6 years ago

Closes #1067

As a result of this PR, whitelisted addresses added will be validated against the tier's supply if maxCap > supply then address won't be added.

Expected behavior:

  1. When adding whitelisted addresses from a CSV, address whose maxCap is greater than the tier's supply will be discarded.
    • If there's an address discarded using this method a modal will be prompted informing the user
  2. When adding a whitelisted address using the form, maxCap will be validated against supply
  3. If there's at least one address in the list of whitelisted addresses, then supply field will be disabled (mimicking the decimals - reserved addresses behavior in stepTwo)
dennis00010011b commented 6 years ago

@fernandomg Dutch - Step3: field 'Supply' isn't disabled if whitelisted address added

screen shot 2018-08-08 at 11 41 29
BlackDuckCoPilot commented 6 years ago

Black Duck Security Report

Merging #1073 into 2.0 will not change security risk.

Click here to see full report

fernandomg commented 6 years ago

Thanks, @dennis00010011b just added the same behavior for Dutch Auction supply. Now it gets disabled when there's at least one whitelisted address loaded.