(Bug) Keep data between the steps (Step 3)

[mariano-aguero]

This is an integration PR for the step 3.

How to test it and what to test:

• Go to the home
• Create a crowdsale
• In the first step, press button "New crowdsale"
• Select the type of strategy
• Go to the second step
• Go back to step 1
• Should keep the selected strategy
• Refresh the step 1 page
• Should keep the selected strategy
• Got to the second step
• Complete the form
• Refresh the page, should keep the data
• Add reserved tokens
• Refresh the page, should keep the data
• Got to the third step
• Complete the form
• Refresh the page, should keep the data
• Go to the home, and press button "New crowdsale"
• The selected strategy must be the default, "WHITELIST WITH CAP"
• Go to the second step
• The form must be empty

[dennis00010011b]

@mariano-aguero Dutch-Step3: flag burn excess lost state after page refreshed Steps:

1. Select Dutch, go to Step2
2. Fill out Step2 with valid data
3. Go to Step3
4. Set 'YES' for checkbox burn excess

5. Refresh page (or go back and forward), observe checkbox burn excess

   Actual result:

   • checkbox burn excess doesn't keep data

[BlackDuckCoPilot]

Black Duck Security Report

Merging #1081 into 2.0-steps-integration will not change security risk.

Added Components

Clean: 1

Click here to see full report

[dennis00010011b]

@mariano-aguero Minted/Dutch-Step3: warnings are not displayed after refresh Steps:

1. Select Dutch
2. Fill out forms in Step2 with valid data
3. Go to Step 3
4. Enter any invalid data in field MinCap(ex.-1232), warning should be displayed
5. Refresh page, observe field MinCap Try the same with fields Supply, start/end date, min/max rate, custom gasprice

Expected result:

• warnings sholud be dispalyed if data incorrect Actual result:
• warnings are not displayed after refresh

[dennis00010011b]

@mariano-aguero Duplicate declaration "logger"; line 15 ,21

https://github.com/poanetwork/token-wizard/blob/a8da6f97d57075268aa508978d86ad6cc659f659/src/components/stepTwo/index.js#L15

[mariano-aguero]

@dennis00010011b

Duplicate declaration "logger"; line 15 ,21

Fixed in a previous commit, line included from a merge

[mariano-aguero]

@dennis00010011b

Dutch-Step3: flag burn excess lost state after page refreshed

Fixed

[coveralls]

Pull Request Test Coverage Report for Build 2893

• 13 of 134 (9.7%) changed or added relevant lines in 11 files are covered.
• 5 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-0.3%) to 20.388%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/utils/utils.js	8	10	80.0%
src/stores/Web3Store.js	0	3	0.0%
src/stores/GeneralStore.js	2	5	40.0%
src/components/Common/TierBlock.js	1	6	16.67%
src/components/Common/DutchAuctionBlock.js	0	6	0.0%
src/components/stepThree/index.js	0	8	0.0%
src/stores/TierStore.js	0	12	0.0%
src/components/stepThree/GasPriceInput.js	0	25	0.0%
src/components/stepThree/StepThreeFormMintedCapped.js	0	26	0.0%
src/components/stepThree/StepThreeFormDutchAuction.js	1	32	3.13%
<!--	Total:	13	134	9.7%	-->

Files with Coverage Reduction	New Missed Lines	%
src/components/Common/DutchAuctionBlock.js	1	6.12%
src/components/stepThree/GasPriceInput.js	4	0.0%
<!--	Total:	5		-->

Totals
Change from base Build 2887:	-0.3%
Covered Lines:	883
Relevant Lines:	3713

---

💛 - Coveralls

[mariano-aguero]

@dennis00010011b

Dutch: possible to add 2nd tier

Fixed

[dennis00010011b]

@mariano-aguero Step3:

• incorrect placeholder for start/end time
  • no default values for checkboxes

Steps for reproduce:

• proceed to Step3(doesn't matter Minted or Dutch)
• observe start/end date fields
• observe checkboxes

[dennis00010011b]

@mariano-aguero Step3 page is unresponsive:

• can't set checkbox, it leads to crash
• can't fill out fields, it is delayed

[mariano-aguero]

@dennis00010011b

incorrect placeholder for start/end time no default values for checkboxes

Step3 page is unresponsive

Update the repository, create a new crowdsale, it should work. This behavior is due to the fact that the first tier was not initialized correctly and the storage has inconsistent data

[dennis00010011b]

@mariano-aguero Minted/Dutch-Step3: field supply disabled if switch whitelist from enabled to disabled Steps:

1. Select Minted(or Dutch)
2. Proceed to Step 3
3. Fill out field Supply with valid value
4. Enable whitelist and add 1 address
5. Disable whitelist.
6. Observe field Supply

Expected result: Field Supply should be enabled if no whitelist addresses or whitelist disabled

[mariano-aguero]

@dennis00010011b

Minted/Dutch-Step3: field supply disabled if switch whitelist from enabled to disabled

Fixed

Minted/Dutch-Step3: warnings are not displayed after refresh

Fixed

Dutch: possible to add 2nd tier

Fixed

Run test

[dennis00010011b]

@mariano-aguero Tested it . No issues were found

[mariano-aguero]

@fernandomg

Another thing, the error message is wrong since always... as it should be >=0.1

Done

I'm getting an error when Custom Gas Price is selected..

Fixed

[dennis00010011b]

@mariano-aguero Step3-Custom gasprice: no error message if value = 0 Steps for reproduce:

1. Proceed to Step 3
2. Set checkbox 'Custom gasprice'

Possible solution : make default value 0.1 , not 0.

[dennis00010011b]

@mariano-aguero Minted/Dutch-Step3: form is cleared if gasprice checkbox is changed Steps:

1. Proceed to Step 3 with valid data
2. Fill out fields Supply, Rate, MinCap
3. Set checkboxes 'Allow modify', 'Whtelist enabled'
4. Set checkbox 'Normal' in section gasprice
5. Observe fields Supply, Rate, MinCap, checkboxes 'Allow modify', 'Whtelist enabled'

Actual result: fields empty, checkboxes in condition by default https://www.useloom.com/share/f4328c5875a2405ca729f24a98fe157f

[mariano-aguero]

@dennis00010011b

Step3-Custom gasprice: no error message if value = 0

Done

Minted/Dutch-Step3: form is cleared if gasprice checkbox is changed

Done

[mariano-aguero]

Updated with changes from branch 2.0

[mariano-aguero]

@dennis00010011b Could you check the changes of the previous comment?

[dennis00010011b]

@mariano-aguero
Tested. No issues were found.