(Bug) Keep data between the steps (Step 4 - Publish && Step 5 - Contribution Page)

poanetwork / token-wizard

(Discontinued) TokenWizard is an DApp to create and manage crowdsale and token contracts using a simple UI

MIT License

384 stars 215 forks source link

(Bug) Keep data between the steps (Step 4 - Publish && Step 5 - Contribution Page) #1097

Closed mariano-aguero closed 6 years ago

mariano-aguero commented 6 years ago

@dennis00010011b Can you check this two steps with this branch? I Perform some tests and it seems to work well, I would need your expert eye

Thanks in advance

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 2926

7 of 158 (4.43%) changed or added relevant lines in 14 files are covered.
7 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.5%) to 20.139%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/utils/blockchainHelpers.js	0	1	0.0%
src/utils/alerts.js	0	2	0.0%
src/stores/Web3Store.js	0	3	0.0%
src/stores/GeneralStore.js	3	6	50.0%
src/components/Common/TierBlock.js	1	6	16.67%
src/components/Common/DutchAuctionBlock.js	0	6	0.0%
src/utils/utils.js	1	10	10.0%
src/components/stepThree/index.js	0	10	0.0%
src/stores/TierStore.js	0	12	0.0%
src/components/stepFour/index.js	0	18	0.0%
<!--	Total:	7	158	4.43%	-->

Files with Coverage Reduction	New Missed Lines	%
src/components/Common/DutchAuctionBlock.js	1	6.12%
src/components/stepFour/index.js	2	0.0%
src/components/stepThree/GasPriceInput.js	4	0.0%
<!--	Total:	7	-->

Totals
Change from base Build 2887:	-0.5%
Covered Lines:	876
Relevant Lines:	3726

💛 - Coveralls

dennis00010011b commented 6 years ago

@mariano-aguero Probably it should be separate issue Step4-deployment process: user able to change network and continue deployment Steps for reproduce:

Set network 'Sokol' in Nifty wallet
Step 1: select Minted
Proceed through Step1-Step3 with valid data
Step4: confirm 2 transactions
Nifty wallet: switch network to Ropsten

Expected result:

should be warning which prevent from continue deployment
user won't able to continue deployment unless switch back to pristine network

Actual result:

user able to continue and finish deployment with other network

dennis00010011b commented 6 years ago

@mariano-aguero Crowdsale page: transaction is generated if user switch between Publish and Crowdsale pages Steps:

Create Minted crowdsale with any valid parameters, proceed until Crowdsale page
Go back to Publish page
Click button 'Continue' and go forward to Crowdsale page
Observe Wallet, new transactions

Actual result:

new transaction is generated each time when user switchs between Publish and crowdsale pages

https://www.useloom.com/share/bca7bd600b6d406b9c13bcb70c28ac0a

mariano-aguero commented 6 years ago

Hi @dennis00010011b

Probably it should be separate issue Step4-deployment process: user able to change network and continue deployment

Done in this branch

How to reproduce it:

Create a crowdsale and fill out the forms until you reach step 4
Perform only the first transaction
Change the network from nifty wallet or metamask
The page has to be refreshed and a warning will appear

mariano-aguero commented 6 years ago

@dennis00010011b

Crowdsale page: transaction is generated if user switch between Publish and Crowdsale pages

Fixed

dennis00010011b commented 6 years ago

@mariano-aguero Issue that isn't related RP's feature but anyway. Minted- Publish page: additional tier is rendered after each page refreshing

dennis00010011b commented 6 years ago

@mariano-aguero In the case when user switches between network on Step4/Publish page the warning should look like warning from contribution page in the same situation

Now

Should be

dennis00010011b commented 6 years ago

@mariano-aguero Step 4: transaction is generated after each page refreshing Steps:

Create a crowdsale and fill out the forms until you reach step 4. Use any network.
Refresh the page
Observe count of transaction in Nifty wallet

mariano-aguero commented 6 years ago

@dennis00010011b

Issue that isn't related RP's feature but anyway.

An additional tier no longer appears

https://www.useloom.com/share/56c9e4fbb6ea4f748fafb2b9405e8ca2

mariano-aguero commented 6 years ago

@dennis00010011b

In the case when user switches between network on Step4/Publish page the warning should look like warning from contribution page in the same situation

Change alert

mariano-aguero commented 6 years ago

@dennis00010011b

Step 4: transaction is generated after each page refreshing

Speaking with @fernandomg , we thought that the user should cancel the previous transaction (reject). The solution to this problem would imply a very high programming cost which I do not think is the time to face. I think we could create an issue for it and work it after the design application, Do you agree?

dennis00010011b commented 6 years ago

@mariano-aguero Ok,I agree. I'll create an issue

dennis00010011b commented 6 years ago

@mariano-aguero https://github.com/poanetwork/token-wizard/pull/1097#issuecomment-414665526

User able to finish deployment without signing all transactions Steps:

Set up account to Sokol network.
Start create the Minted crowdsale, in Step 4 sign 2-3 transaction
Switch to Kovan network.
Confirm warning and proceed with button Continue until Contribution page is open.
Switch back to Sokol network.

Actual result:

created crowdsale doesn't match given in Step3 parameters (because not all contracts were deployed)

Possible solution: 1) in Step 4 disable button continue if not all transaction signed 2) display warning without confirmation button, until user switches back to pristine network

mariano-aguero commented 6 years ago

@dennis00010011b

User able to finish deployment without signing all transactions

I apply the solution in Step 4 disable button continue if not all transaction signed

Can you check it ? Thanks