Closed mariano-aguero closed 6 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/utils/blockchainHelpers.js | 0 | 1 | 0.0% | ||
src/utils/alerts.js | 0 | 2 | 0.0% | ||
src/stores/Web3Store.js | 0 | 3 | 0.0% | ||
src/stores/GeneralStore.js | 3 | 6 | 50.0% | ||
src/components/Common/TierBlock.js | 1 | 6 | 16.67% | ||
src/components/Common/DutchAuctionBlock.js | 0 | 6 | 0.0% | ||
src/utils/utils.js | 1 | 10 | 10.0% | ||
src/components/stepThree/index.js | 0 | 10 | 0.0% | ||
src/stores/TierStore.js | 0 | 12 | 0.0% | ||
src/components/stepFour/index.js | 0 | 18 | 0.0% | ||
<!-- | Total: | 7 | 158 | 4.43% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
src/components/Common/DutchAuctionBlock.js | 1 | 6.12% | ||
src/components/stepFour/index.js | 2 | 0.0% | ||
src/components/stepThree/GasPriceInput.js | 4 | 0.0% | ||
<!-- | Total: | 7 | --> |
Totals | |
---|---|
Change from base Build 2887: | -0.5% |
Covered Lines: | 876 |
Relevant Lines: | 3726 |
@mariano-aguero Probably it should be separate issue Step4-deployment process: user able to change network and continue deployment Steps for reproduce:
Expected result:
Actual result:
@mariano-aguero Crowdsale page: transaction is generated if user switch between Publish and Crowdsale pages Steps:
Actual result:
https://www.useloom.com/share/bca7bd600b6d406b9c13bcb70c28ac0a
Hi @dennis00010011b
Probably it should be separate issue Step4-deployment process: user able to change network and continue deployment
Done in this branch
How to reproduce it:
@dennis00010011b
Crowdsale page: transaction is generated if user switch between Publish and Crowdsale pages
Fixed
@mariano-aguero Issue that isn't related RP's feature but anyway. Minted- Publish page: additional tier is rendered after each page refreshing
@mariano-aguero In the case when user switches between network on Step4/Publish page the warning should look like warning from contribution page in the same situation
Now
Should be
@mariano-aguero Step 4: transaction is generated after each page refreshing Steps:
@dennis00010011b
Issue that isn't related RP's feature but anyway.
An additional tier no longer appears
https://www.useloom.com/share/56c9e4fbb6ea4f748fafb2b9405e8ca2
@dennis00010011b
In the case when user switches between network on Step4/Publish page the warning should look like warning from contribution page in the same situation
Change alert
@dennis00010011b
Step 4: transaction is generated after each page refreshing
Speaking with @fernandomg , we thought that the user should cancel the previous transaction (reject). The solution to this problem would imply a very high programming cost which I do not think is the time to face. I think we could create an issue for it and work it after the design application, Do you agree?
@mariano-aguero Ok,I agree. I'll create an issue
@mariano-aguero https://github.com/poanetwork/token-wizard/pull/1097#issuecomment-414665526
User able to finish deployment without signing all transactions Steps:
Actual result:
Possible solution:
1) in Step 4 disable button continue
if not all transaction signed
2) display warning without confirmation button, until user switches back to pristine network
@dennis00010011b
User able to finish deployment without signing all transactions
I apply the solution in Step 4 disable button continue if not all transaction signed
Can you check it ? Thanks
@dennis00010011b Can you check this two steps with this branch? I Perform some tests and it seems to work well, I would need your expert eye
Thanks in advance