search

poanetwork / token-wizard

(Discontinued) TokenWizard is an DApp to create and manage crowdsale and token contracts using a simple UI
MIT License
384 stars 215 forks source link

(Bug) Keep data between the steps (Integration Branch) #1104

Closed mariano-aguero closed 5 years ago

mariano-aguero commented 6 years ago

This is a PR with an integration branch Closes #1033

Pull request covering the steps

Once the steps are merged, an integral test would have to be carried out

BlackDuckCoPilot commented 6 years ago

Black Duck Security Report

Merging #1104 into 2.0 will not change security risk.

Click here to see full report

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 3000

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/manage/index.js 0 1 0.0%
src/stores/TokenStore.js 0 2 0.0%
src/App.js 0 2 0.0%
src/utils/alerts.js 0 2 0.0%
src/stores/GeneralStore.js 5 8 62.5%
src/stores/Web3Store.js 1 4 25.0%
src/components/stepTwo/StepTwoForm.js 6 10 60.0%
src/components/stepTwo/index.js 0 4 0.0%
src/components/Common/TierBlock.js 1 6 16.67%
src/components/Common/DutchAuctionBlock.js 0 6 0.0%
<!-- Total: 60 310 19.35% -->
Files with Coverage Reduction New Missed Lines %
src/App.js 1 0.0%
src/components/Common/DutchAuctionBlock.js 1 6.12%
src/components/stepOne/index.js 3 0.0%
src/components/Home/index.js 3 0.0%
src/components/stepFour/index.js 4 0.0%
src/components/stepThree/GasPriceInput.js 5 0.0%
<!-- Total: 17 -->
Totals Coverage Status
Change from base Build 2996: -0.3%
Covered Lines: 884
Relevant Lines: 3783
💛 - Coveralls
dennis00010011b commented 6 years ago

@mariano-aguero Issue in Step3: field Supply disabled if whitelist enabled, both for Minted and Dutch. Expected: field Supply should be disabled if at least 1 whitelisted address has added

screen shot 2018-08-28 at 9 00 12 am
mariano-aguero commented 6 years ago

Hi @dennis00010011b

Issue in Step3: field Supply disabled if whitelist enabled, both for Minted and Dutch.

I change how validate the supply input, Regards

dennis00010011b commented 6 years ago

Hi @mariano-aguero

I change how validate the supply input, Regards

It fixed

fernandomg commented 5 years ago

Before merging/approving this PR, this must be solved: https://github.com/poanetwork/token-wizard/pull/1103#issuecomment-415080605

mariano-aguero commented 5 years ago

@dennis00010011b

Before merging/approving this PR, this must be solved: #1103 (comment)

Can you check de fix for the above comment? Thanks

dennis00010011b commented 5 years ago

@mariano-aguero it fixed https://github.com/poanetwork/token-wizard/pull/1103#issuecomment-415080605

dennis00010011b commented 5 years ago

@mariano-aguero Contribution page: app crashed if network switched Steps:

  1. Set network Sokol
  2. Create Minted (or Dutch) crowdsale with any valid parameters
  3. Open contribution page as an owner
  4. Set network Rinkeby(or any other)
  5. Confirm warning, observe page.

Expected result:
-warning should be displayed 'switch to Sokol network .........' Actual result :

screen shot 2018-09-03 at 3 50 28 am

contrib_grash.log

mariano-aguero commented 5 years ago

@dennis00010011b

Contribution page: app crashed if network switched

I change how network is validated, separate it from the rest of the environment check