Closed mariano-aguero closed 5 years ago
Merging #1104 into 2.0 will not change security risk.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/components/manage/index.js | 0 | 1 | 0.0% | ||
src/stores/TokenStore.js | 0 | 2 | 0.0% | ||
src/App.js | 0 | 2 | 0.0% | ||
src/utils/alerts.js | 0 | 2 | 0.0% | ||
src/stores/GeneralStore.js | 5 | 8 | 62.5% | ||
src/stores/Web3Store.js | 1 | 4 | 25.0% | ||
src/components/stepTwo/StepTwoForm.js | 6 | 10 | 60.0% | ||
src/components/stepTwo/index.js | 0 | 4 | 0.0% | ||
src/components/Common/TierBlock.js | 1 | 6 | 16.67% | ||
src/components/Common/DutchAuctionBlock.js | 0 | 6 | 0.0% | ||
<!-- | Total: | 60 | 310 | 19.35% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
src/App.js | 1 | 0.0% | ||
src/components/Common/DutchAuctionBlock.js | 1 | 6.12% | ||
src/components/stepOne/index.js | 3 | 0.0% | ||
src/components/Home/index.js | 3 | 0.0% | ||
src/components/stepFour/index.js | 4 | 0.0% | ||
src/components/stepThree/GasPriceInput.js | 5 | 0.0% | ||
<!-- | Total: | 17 | --> |
Totals | |
---|---|
Change from base Build 2996: | -0.3% |
Covered Lines: | 884 |
Relevant Lines: | 3783 |
@mariano-aguero Issue in Step3: field Supply disabled if whitelist enabled, both for Minted and Dutch. Expected: field Supply should be disabled if at least 1 whitelisted address has added
Hi @dennis00010011b
Issue in Step3: field Supply disabled if whitelist enabled, both for Minted and Dutch.
I change how validate the supply input, Regards
Hi @mariano-aguero
I change how validate the supply input, Regards
It fixed
Before merging/approving this PR, this must be solved: https://github.com/poanetwork/token-wizard/pull/1103#issuecomment-415080605
@dennis00010011b
Before merging/approving this PR, this must be solved: #1103 (comment)
Can you check de fix for the above comment? Thanks
@mariano-aguero it fixed https://github.com/poanetwork/token-wizard/pull/1103#issuecomment-415080605
@mariano-aguero Contribution page: app crashed if network switched Steps:
Expected result:
-warning should be displayed 'switch to Sokol network .........'
Actual result :
@dennis00010011b
Contribution page: app crashed if network switched
I change how network is validated, separate it from the rest of the environment check
This is a PR with an integration branch Closes #1033
Pull request covering the steps
Once the steps are merged, an integral test would have to be carried out