poanetwork / token-wizard

(Discontinued) TokenWizard is an DApp to create and manage crowdsale and token contracts using a simple UI
MIT License
384 stars 215 forks source link

(Fix) Add invalidCrowdsaleProxyAlert #1106

Closed mariano-aguero closed 6 years ago

mariano-aguero commented 6 years ago

Closes #1044

How to test it: https://www.useloom.com/share/d3613258b92d4d1c91d1d931227e2b7e

Test run: screenshot_20180822_204703

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 2882


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/manage/index.js 0 2 0.0%
src/utils/alerts.js 0 2 0.0%
src/components/crowdsale/index.js 0 8 0.0%
src/utils/utils.js 7 15 46.67%
src/components/contribute/index.js 0 9 0.0%
<!-- Total: 7 36 19.44% -->
Files with Coverage Reduction New Missed Lines %
src/utils/utils.js 1 55.33%
src/components/contribute/index.js 3 0.0%
src/components/manage/index.js 3 0.0%
<!-- Total: 7 -->
Totals Coverage Status
Change from base Build 2857: -0.002%
Covered Lines: 833
Relevant Lines: 3573

💛 - Coveralls
dennis00010011b commented 6 years ago

@mariano-aguero In the case with Manage page the warning displayed together with loader. As a result the warning unreadable and unclickable.

screen shot 2018-08-22 at 10 22 43 pm
mariano-aguero commented 6 years ago

Hi @dennis00010011b I hide the loader in the catch block. Can you check it?

dennis00010011b commented 6 years ago

@mariano-aguero @vbaranov Tested it. No issues were found