(Bug) Dutch- Publish page: uploaded file'Auth-os_addresses.txt' contains wrong names of contracts

poanetwork / token-wizard

(Discontinued) TokenWizard is an DApp to create and manage crowdsale and token contracts using a simple UI

MIT License

384 stars 215 forks source link

(Bug) Dutch- Publish page: uploaded file'Auth-os_addresses.txt' contains wrong names of contracts #1117

Closed mariano-aguero closed 5 years ago

mariano-aguero commented 5 years ago

Closes #1101

Check strategy of the crowdsale
Create labels regarding selected strategy

dennis00010011b commented 5 years ago

@mariano-aguero For avoid to create one more PR it could be nice to make some additional work in this PR: add to Auth-os_addresses.txt for Minted crowdsale two contract’s adresses:

Sale_manager ( var REACT_APP_MINTED_CAPPED_CROWDSALE_MANAGER_ADDRESS)
1. Token manager ( var REACT_APP_MINTED_CAPPED_TOKEN_MANAGER_ADDRESS)

mariano-aguero commented 5 years ago

@dennis00010011b

Can you specific the ID of the issue ?

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 3024

0 of 13 (0.0%) changed or added relevant lines in 1 file are covered.
98 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.1%) to 20.25%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/components/stepFour/utils.js	0	13	0.0%
<!--	Total:	0	13	0.0%	-->

Files with Coverage Reduction	New Missed Lines	%
src/components/stepFour/constants.js	1	0.0%
src/components/stepFour/utils.js	34	0.0%
src/components/stepFour/index.js	63	0.0%
<!--	Total:	98	-->

Totals
Change from base Build 2976:	-0.1%
Covered Lines:	834
Relevant Lines:	3610

💛 - Coveralls

dennis00010011b commented 5 years ago

@mariano-aguero Sorry! https://github.com/poanetwork/token-wizard/issues/1118

mariano-aguero commented 5 years ago

@dennis00010011b

For avoid to create one more PR it could be nice to make some additional work in this PR: add to Auth-os_addresses.txt for Minted crowdsale two contract’s adresses:

Done

Closes #1118

dennis00010011b commented 5 years ago

@mariano-aguero Dutch-Publish page: app crashed while attempting to download file with metadata Steps for reproducing: create Dutch crowdsale with any valid parameters and proceed until Publish page. Issue not reproducible for Minted

dutch_download_crach.log

mariano-aguero commented 5 years ago

@dennis00010011b

Dutch-Publish page: app crashed while attempting to download file with metadata ...

I added a validation. This is because there is no environment variable "manager" for the selected strategy type (Dutch strategy, see the example env file)