coveralls
commented
5 years ago Pull Request Test Coverage Report for Build 2987
- 0 of 7 (0.0%) changed or added relevant lines in 1 file are covered.
- 2 unchanged lines in 2 files lost coverage.
- Overall coverage decreased (-0.003%) to 20.344%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| src/App.js | 0 | 7 | 0.0% | ||
| <!-- | Total: | 0 | 7 | 0.0% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| src/components/Common/ModalContainer.js | 1 | 0.0% | ||
| src/index.js | 1 | 0.0% | ||
| <!-- | Total: | 2 | --> |
| Totals | |
|---|---|
| Change from base Build 2986: | -0.003% |
| Covered Lines: | 834 |
| Relevant Lines: | 3591 |
vbaranov
dennis00010011b
Description:
Pull request to temporary branch origin/integration/#1082-new-design where we can continually merge the latest "new styling" working branches (#1083, #1084, etc.), and the 2.0 PRs, so as to keep everything as updated as possible.
As for the #1083 tasks: I don't think that extracting and adding all the new assets is the best thing to do at this step, so I will be doing that screen by screen / component by component, unless somebody needs some asset to do their job.
How to test:
1- There should be some new folders and files, preparing the terrain for the new styles, check that those exist:
token-wizard/src/assets/stylesheets/v2.0 contains some new folders, files, and explanations. token-wizard/src/assets/images/v2.0 has some folders and images for the new styles
This structure will allow us to have the old and new styles in parallel, minimizing the risk of losing something currently working. Once the work is finished, we'll delete the old files and that's it.
2- It's possible to switch styles using:
http://dappurl/?uiversion=2 (v2, currently ugly and broken) http://dappurl/?uiversion=1 (v1 working version) http://dappurl/ a mix of versions 1 and 2, to compensate for whatever styles are not done yet.
This should work.
When we finish we will also delete the old styles.