poanetwork / token-wizard

(Discontinued) TokenWizard is an DApp to create and manage crowdsale and token contracts using a simple UI
MIT License
384 stars 215 forks source link

(Feature) Add ABI-Encoded params for Proxy Contracts #1120

Closed fernandomg closed 5 years ago

fernandomg commented 5 years ago

Closes #1038

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 3005


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/stepFour/index.js 0 4 0.0%
<!-- Total: 0 4 0.0% -->
Files with Coverage Reduction New Missed Lines %
src/components/stepFour/index.js 1 0.0%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 2996: -0.02%
Covered Lines: 834
Relevant Lines: 3597

💛 - Coveralls
dennis00010011b commented 5 years ago

@fernandomg I can't verify contract with ABI-encoded parameters from publish page. Error received in Ropsten etherscan : Error! Invalid constructor arguments provided. Please verify that they are in ABI-encoded format. I have tried both for Minted and Dutch strategy

Network: Ropsten

Crowdsale Proxy Address: 0x5c13db37d7ef917291e51a9a1f50c45178a15edd (Dutch) https://ropsten.etherscan.io/address/0x5c13db37d7ef917291e51a9a1f50c45178a15edd

ABI-Encoded (copied from Publish page):

0x00000000000000000000000056b2e3c3cff7f3921dc2e0f8b8e20d1eec29216b00000000000000000000000000000000000000000000003635c9adc5dea0000000000000000000000000000000000000000000000000000ad78ebc5ac6200000000000000000000000000000000000000000000000000000002386f26fc1000000000000000000000000000000000000000000000000000000038d7ea4c68000000000000000000000000000000000000000000000000000000000000004c7ac000000000000000000000000000000000000000000000000000000005b8c08c4000000000000000000000000000000000000000000000000000000000000000000000000000000000000000056b2e3c3cff7f3921dc2e0f8b8e20d1eec29216b0000000000000000000000000000000000000000000000000000000000000000
screen shot 2018-09-02 at 9 02 43 am
fernandomg commented 5 years ago

Thanks for the review @dennis00010011b. It's fixed now.

Keep in mind to properly set the Compiler and Optimization options properly.

image

Thanks @vbaranov for the clarification.