fernandomg
commented
5 years ago @gabitoesmiapodo In Firefox it looks a bit weird
Desktop
Mobile-view in Firefox Desktop (it doesn't scrolls)
Closed gabitoesmiapodo closed 5 years ago
fernandomg
commented
5 years ago @gabitoesmiapodo In Firefox it looks a bit weird
Desktop
Mobile-view in Firefox Desktop (it doesn't scrolls)
dennis00010011b
commented
5 years ago @gabitoesmiapodo Desktop, MacOS, Chrome Version 68.0.3440.106 (Official Build) (64-bit) Choose crowdsale list: selected item isn't highlighted
dennis00010011b
commented
5 years ago @gabitoesmiapodo Desktop, MacOS, Chrome Version 68.0.3440.106 (Official Build) (64-bit) Home page:
dennis00010011b
commented
5 years ago @gabitoesmiapodo
Desktop, MacOS, Chrome Version 68.0.3440.106 (Official Build) (64-bit)
Home page: Auth_os text doesn't look like link
fernandomg
commented
5 years ago Adding to https://github.com/poanetwork/token-wizard/pull/1122#issuecomment-418189319
The mouse cursor doesn't indicate that the row is clickable.
An example from v1.0
fernandomg
commented
5 years ago And it seems, that style of the list of addresses popup differs from that one from the layout app.zeplin.io/project/5b38672635f4e0a932ec246f/screen/5b3895a9c615fa114ec71dde. Will it be subject of another PR?
@vbaranov I'm not understanding that new screen. Looks like an enhanced ManageScreen?
What confuses me is this mock https://app.zeplin.io/project/5b38672635f4e0a932ec246f/screen/5b3895a97279af2b6e2ddf3d that treats each item as a list of ordered steps (taking into account to how they are highlighted in the bullet-list)
gabitoesmiapodo
commented
5 years ago @fernandomg
@dennis00010011b
@vbaranov
For now this popup it's just restyled like the modal windows in the new designs.
fernandomg
commented
5 years ago @gabitoesmiapodo everything fixed.
Now the main-info box is not properly aligned vertically (in both, firefox and chrome).
It depends on the resolution though because there are cases where it's properly aligned.
vbaranov
commented
5 years ago What confuses me is this mock https://app.zeplin.io/project/5b38672635f4e0a932ec246f/screen/5b3895a97279af2b6e2ddf3d that treats each item as a list of ordered steps (taking into account to how they are highlighted in the bullet-list)
@fernandomg @gabitoesmiapodo Sorry for confusion. I am not about the list of steps in the left menu or changing the logic. I am just talking about the representation of the modal window.
From this PR it looks like
But from the layout it should be like:
But I am sure, that it could be made in a separate PR and it shouldn't stop to merge this one.
gabitoesmiapodo
commented
5 years ago @fernandomg I think it might be that you are forgetting to add the ?uiversion=2 parameter? That's what happens to me, at least.
Added a few CSS improvements anyway, just in case.
If that's not the case I will need some more info, as screen resolution, etc.
@vbaranov
I just adapted the general modal windows and tables styles to look like this https://zpl.io/2ymGX4n and that's why it looks that way now. But that will not be the final implementation.
That said, it will be necessary more than a simple modal restyling to make this:
https://zpl.io/blpk4Q0 https://zpl.io/brN07d5
(or this, I'm not sure which design should be implemented, or if this is a different section... but both are very alike)
https://zpl.io/brNpKB7 https://zpl.io/2vYjBkv https://zpl.io/2EA4wpn
because it changes completely what we have now, and that's why I think it would be better to implement that feature in a new issue.
vbaranov
commented
5 years ago @gabitoesmiapodo ok, let's leave it as is for now. Representation of this modal window needs to be discussed with a designer...
fernandomg
commented
5 years ago I've added tests for the Home Component.
Updated tests for Load and CrowdsaleList components as well.
Also modified Home component and created a navigateTo method to facilitate testing.
All test cases related to CrowdsaleList weren't added as it will be moved to a new component instead of being displayed as a modal window.
There's a test case that failed and due to time constraints, I decided to create a separate issue (#1129) to solve it as it's taking too much time.
coveralls
commented
5 years ago | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| src/components/manage/index.js | 0 | 1 | 0.0% | ||
| src/stores/index.js | 1 | 2 | 50.0% | ||
| src/components/stepFour/constants.js | 0 | 1 | 0.0% | ||
| src/components/Common/ModalContainer.js | 0 | 1 | 0.0% | ||
| src/utils/alerts.js | 0 | 2 | 0.0% | ||
| src/stores/TokenStore.js | 0 | 2 | 0.0% | ||
| src/stores/GeneralStore.js | 5 | 8 | 62.5% | ||
| src/stores/Web3Store.js | 1 | 4 | 25.0% | ||
| src/App.js | 0 | 3 | 0.0% | ||
| src/components/stepTwo/StepTwoForm.js | 6 | 10 | 60.0% | ||
| <!-- | Total: | 77 | 365 | 21.1% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| src/components/stepFour/utils.js | 1 | 0.0% | ||
| src/components/index.js | 1 | 0.0% | ||
| src/components/Common/DutchAuctionBlock.js | 1 | 6.12% | ||
| src/components/Common/CrowdsalesList.js | 1 | 70.0% | ||
| src/components/stepThree/index.js | 1 | 0.0% | ||
| src/App.js | 2 | 0.0% | ||
| src/components/stepOne/index.js | 2 | 0.0% | ||
| src/components/stepThree/GasPriceInput.js | 5 | 0.0% | ||
| src/components/stepFour/index.js | 6 | 0.0% | ||
| src/components/Common/WhitelistInputBlock.js | 9 | 2.61% | ||
| <!-- | Total: | 41 | --> |
| Totals | |
|---|---|
| Change from base Build 2997: | -1.9% |
| Covered Lines: | 811 |
| Relevant Lines: | 3716 |
Description:
Implemented the new designs for the Token Wizard's home page, and also some common elements like modal windows, and a full screen loading component.
Notes:
Designs (Zeplin):
Some screenshots:
Desktop:
Tablet:
Mobile: