(Bug) Publish page: start/end time have no timezone

poanetwork / token-wizard

(Discontinued) TokenWizard is an DApp to create and manage crowdsale and token contracts using a simple UI

MIT License

384 stars 215 forks source link

(Bug) Publish page: start/end time have no timezone #1136

Closed mariano-aguero closed 5 years ago

mariano-aguero commented 5 years ago

Closes #1126 and #1127

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 3211

12 of 56 (21.43%) changed or added relevant lines in 7 files are covered.
67 unchanged lines in 4 files lost coverage.
Overall coverage increased (+0.005%) to 19.707%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/components/contribute/index.js	0	3	0.0%
src/components/stepFour/index.js	0	7	0.0%
src/components/crowdsale/utils.js	1	9	11.11%
src/utils/utils.js	6	18	33.33%
src/components/manage/index.js	0	14	0.0%
<!--	Total:	12	56	21.43%	-->

Files with Coverage Reduction	New Missed Lines	%
src/components/stepFour/index.js	1	0.0%
src/components/contribute/index.js	1	0.0%
src/components/manage/index.js	2	0.0%
src/components/stepFour/utils.js	63	0.0%
<!--	Total:	67	-->

Totals
Change from base Build 3105:	0.005%
Covered Lines:	893
Relevant Lines:	3889

💛 - Coveralls

dennis00010011b commented 5 years ago

@mariano-aguero Publish page - time displayed in format: Greenwich time (UTC+0) + local time zone

Let start time is 2018-09-12 11:20 (UTC -0) We have two option how to render time in publish page:

Calculate local machine time , it will be 2018-09-12 04:20 (UTC -7) for user from Seattle.
Just render UTC+0 time: 2018-09-12 11:20 (UTC -0)

I think 2nd option is enough. The same should be in files

BlackDuckCoPilot commented 5 years ago

Black Duck Security Report

Merging #1136 into 2.0 will not change security risk.

Click here to see full report

fernandomg commented 5 years ago

@mariano-aguero

The start time for the crowdsale is 14:25GMT-3, and indeed it started at that time. But in the summary file downloaded I'm getting a start time of 17:25GMT-3.

Here's a snapshot with that info:

In manage screen, I'm getting 5:25 PM as well.

fernandomg commented 5 years ago

@mariano-aguero continuing with the previous message... despite the crowdsale has started in the UI, I'm not allowed to contribute because the start time was set to 17:25GMT-3 instead.

And you can check that that's the time stored in the contract:

Crowdsale Address: 0x164a545bd972c022ae633760e213aa9ec649f858

dennis00010011b commented 5 years ago

@mariano-aguero manage page: start/end time is displayed as UTC+0000, should be local machine time

dennis00010011b commented 5 years ago

@mariano-aguero Manage page: button Save always enabled Steps:

Create Minted or Dutch crowdsale with valid parameters
Open manage page and observe button Save

mariano-aguero commented 5 years ago

@dennis00010011b

Publish page - time displayed in format: Greenwich time (UTC+0) + local time zone Let start time is 2018-09-12 11:20 (UTC -0) We have two option how to render time in publish page: Calculate local machine time , it will be 2018-09-12 04:20 (UTC -7) for user from Seattle. Just render UTC+0 time: 2018-09-12 11:20 (UTC -0) I think 2nd option is enough. The same should be in files

Done

manage page: start/end time is displayed as UTC+0000, should be local machine time

Done

mariano-aguero commented 5 years ago

@fernandomg

The start time for the crowdsale is 14:25GMT-3, and indeed it started at that time. But in the summary file downloaded I'm getting a start time of 17:25GMT-3.

Done

continuing with the previous message... despite the crowdsale has started in the UI, I'm not allowed to contribute because the start time was set to 17:25GMT-3 instead

Done

mariano-aguero commented 5 years ago

@dennis00010011b and @fernandomg

Pending solution problems:

Manage page: button Save always enabled
Contribution not allowed

dennis00010011b commented 5 years ago

@mariano-aguero Is it ready for review?

mariano-aguero commented 5 years ago

@dennis00010011b

I need to solve the problem in the contribution page

mariano-aguero commented 5 years ago

@dennis00010011b

Manage page: button Save always enabled Contribution not allowed

Done, now is ready

Regards

dennis00010011b commented 5 years ago

@mariano-aguero Tested with Minted crowdsale, modifiable, 1 tier, no whitelist Sokol, proxyID 0xaa4a8cf344ec89e5708c7b642ad23ea4e13445ef Manage page:

Button 'Save ' always enabled Should be enabled only if any changing was made
1. End time isn't modifiable End time should be modifiable before tier's start if tier is modifiable
2. Can not change mincap after start of tier
3. Changing mincap before start of crowdsale triggers 2 metamask transaction

dennis00010011b commented 5 years ago

@mariano-aguero Dutch/ Minted- Contribution page: no warning if user tries to contribute before start, transaction is generated

mariano-aguero commented 5 years ago

@dennis00010011b

Dutch/ Minted- Contribution page: no warning if user tries to contribute before start, transaction is generated

Done

mariano-aguero commented 5 years ago

@dennis00010011b

Manage page: Button 'Save ' always enabled Should be enabled only if any changing was made End time isn't modifiable End time should be modifiable before tier's start if tier is modifiable Can not change mincap after start of tier Changing mincap before start of crowdsale triggers 2 metamask transaction

Done