Closed mariano-aguero closed 5 years ago
@mariano-aguero Bottom of crowdsale list is empty Chrome Version 69.0.3497.92 (Official Build) (64-bit)
@mariano-aguero unfriendly warning still here if a wallet not installed
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/App.js | 0 | 1 | 0.0% | ||
src/components/Home/ChooseCrowdsale.js | 5 | 6 | 83.33% | ||
src/components/Home/CreateCrowdsale.js | 7 | 8 | 87.5% | ||
src/components/Common/CrowdsalesList.js | 3 | 5 | 60.0% | ||
src/stores/Web3Store.js | 3 | 8 | 37.5% | ||
src/components/Crowdsales/index.js | 13 | 23 | 56.52% | ||
src/components/StepOne/index.js | 10 | 21 | 47.62% | ||
src/components/Home/utils.js | 2 | 13 | 15.38% | ||
src/utils/blockchainHelpers.js | 15 | 26 | 57.69% | ||
<!-- | Total: | 78 | 131 | 59.54% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
src/stores/ContractStore.js | 1 | 79.17% | ||
src/components/index.js | 1 | 0.0% | ||
src/stores/ReservedTokenStore.js | 1 | 24.44% | ||
src/components/Common/ModalContainer.js | 4 | 0.0% | ||
src/utils/blockchainHelpers.js | 6 | 12.06% | ||
<!-- | Total: | 13 | --> |
Totals | |
---|---|
Change from base Build 3095: | 0.1% |
Covered Lines: | 896 |
Relevant Lines: | 3784 |
Merging #1146 into integration/#1082-new-design will not change security risk.
2 component(s) did not change but have updated security data. This may affect your calculated score.
@dennis00010011b
Bottom of crowdsale list is empty
There is an issue #1145 for this
unfriendly warning still here if a wallet not installed
This warning must exist in the stepOne section and in the crowdsales list section
@mariano-aguero
After closing the modal with the warning message the user remains in the StepOne
screen. Maybe it will be better if it redirects to the Home
screen, to prevent any possible inconsistent state if the user thinks to continue from there.
And there's no option selected by default
@mariano-aguero In regard to tests
Some of the snapshots for this tests are just null
:
Crowdsales/index.spec.js
Home/ChooseCrowdsale.spec.js
Home/CreateCrowdsale.spec.js
Maybe forceUpdate
is not necessary, if you can call enzyme's wrapper.update()
instead, which will be calling forceUpdate
@fernandomg
After closing the modal with the warning message the user remains in the StepOne screen. Maybe it will be better if it redirects to the Home screen, to prevent any possible inconsistent state if the user thinks to continue from there. And there's no option selected by default
Done
Some of the snapshots for this tests are just null
Done
Have a nice weekend :)
@dennis00010011b If you can, give this PR a last review/approval. Thank you.
@mariano-aguero User can close sweet alert by clicking beside of it 3-4 times. As a result it isn't redirect to Home page if a wallet isn't installed https://www.useloom.com/share/c3c2dce05710439899583e31f1fb1b19
@dennis00010011b
Step 1: there's still no option selected by default if Wallet is installed and signed in
Done
User can close sweet alert by clicking beside of it 3-4 times. As a result it isn't redirect to Home page if a wallet isn't installed
Done
Closes #1139
Todo:
How to test it: