(Bug) There is no Proxy contract address in zip archive (Minted capped only)

poanetwork / token-wizard

(Discontinued) TokenWizard is an DApp to create and manage crowdsale and token contracts using a simple UI

MIT License

381 stars 216 forks source link

(Bug) There is no Proxy contract address in zip archive (Minted capped only) #1152

Closed mariano-aguero closed 5 years ago

mariano-aguero commented 5 years ago

Closes #1150

I try to reproduce the error in the sokol network without success I think the crowdsale of the problem is using exec-id , and is not proxy Here is the line where the logical decision is made

https://github.com/poanetwork/token-wizard/blob/2.0/src/components/stepFour/utils.js#L994

Can you checked @dennis00010011b ? If you find a problem, can you make a comment with the steps to reproduce it?

Regards

mariano-aguero commented 5 years ago

I add a screenshot of the file screenshot_20180924_174838

dennis00010011b commented 5 years ago

@mariano-aguero I can't reproduce it too for Minted. But for Dutch file contains execution ID instead proxy address

BlackDuckCoPilot commented 5 years ago

Black Duck Security Report

Merging #1152 into 2.0 will not change security risk.

Click here to see full report

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 3162

0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 19.717%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/components/stepFour/utils.js	0	1	0.0%
<!--	Total:	0	1	0.0%	-->

Totals
Change from base Build 3143:	0.01%
Covered Lines:	884
Relevant Lines:	3847

💛 - Coveralls

mariano-aguero commented 5 years ago

@dennis00010011b

I can't reproduce it too for Minted.

I think is an old contract

But for Dutch file contains execution ID instead proxy address

That is maybe a bug, for Dutch File must contain proxy address? Is ok that ?

dennis00010011b commented 5 years ago

@mariano-aguero Issue is reproducible, actual both for Minted and Dutch. Issue isn't reproducible if it isn't first crowdsale that has created in current build.

Steps:

Clone token-wizard repo to local machine
Execute commands:
- git submodule update --init --recursive --remote
- cp .env.example .env
- npm run start
Create crowdsale(Minted or Dutch) with any parameters
Proceed until Publish page
Download and observe Auth-os_addresses.txt file

Expected result:

file should contain proxy address

Actual result:

file contains execution ID
file contains correct data if it isn't first crowdsale that has created in current build.

mariano-aguero commented 5 years ago

I cant reproduce the problem with this steps, I suggested the creation of a video with all the steps that are made

dennis00010011b commented 5 years ago

@mariano-aguero video https://www.useloom.com/share/08d0ee96022a4f9695c89f7c75b500bb

I corrected step 2 https://github.com/poanetwork/token-wizard/pull/1152#issuecomment-424304994

2. Execute commands:
  - git submodule update --init --recursive --remote
  - cp .env.example .env
  - npm run start

mariano-aguero commented 5 years ago

@dennis00010011b

Can you check it again? Please try to test it in private mode with your browser