search

poanetwork / token-wizard

(Discontinued) TokenWizard is an DApp to create and manage crowdsale and token contracts using a simple UI
MIT License
381 stars 216 forks source link

(Fix) Reserved Token Addresses CSV import #1157

Closed fernandomg closed 5 years ago

fernandomg commented 5 years ago

Closes #1156

dennis00010011b commented 5 years ago

@fernandomg Issue fixed https://github.com/poanetwork/token-wizard/issues/1156 But there is two things more(these can be done here or I can open separate issue ?) :

  1. No validation of token value by decimals, i.e decimal=1, value=0.00001 allowed

    screen shot 2018-09-26 at 8 43 17 am

  2. Field decimals has arrow buttons, user should not be able to set up min value less than defined by decimals. See comment https://github.com/poanetwork/token-wizard/pull/1148#issuecomment-423569768

    screen shot 2018-09-26 at 8 57 22 am
BlackDuckCoPilot commented 5 years ago

Black Duck Security Report

Merging #1157 into integration/#1082-new-design will not change security risk.

Click here to see full report

fernandomg commented 5 years ago

@dennis00010011b Let's consider this issue as fixed.

I created two different issues to address what you pointed out in the comment (#1158 & #1159)