(Feature) Step 2 - CSV file upload improvements

poanetwork / token-wizard

(Discontinued) TokenWizard is an DApp to create and manage crowdsale and token contracts using a simple UI

MIT License

381 stars 216 forks source link

(Feature) Step 2 - CSV file upload improvements #1163

Closed mariano-aguero closed 5 years ago

mariano-aguero commented 5 years ago

Closes #1149

BlackDuckCoPilot commented 5 years ago

Black Duck Security Report

Merging #1163 into integration/#1082-new-design will not change security risk.

Click here to see full report

dennis00010011b commented 5 years ago

@mariano-aguero Validator of uploaded CSV detects errors but there is no warning message in cases if :

typo in dimension unit
incorrect value (typo or negative)
numbers of column more than 3

Used data:

0xE743AaF851663e84D3Ec3648638662a6c41cEe2A, abrakadabra, 5.0505
0x5d2Bf1496242D32785d1A386410b7F157e17F42d,tokens,-50
0xf9180fF7650f808EB08C1EA1C9D0f85436d9a39D,percentage,-100
0xd03ea8624c8c5987235048901fb614fdca89b117,tokens,50,1
0xf79915BEFF157fE483D29875635C6Fe24De910B3,tokens,tokens

dennis00010011b commented 5 years ago

@mariano-aguero If CSV file contains rows with the same address and dimension but different values then will be added only one address (which latest). In this case warning contains incorrect number of added addresses

Used data:

0x95ced938f7991cd0dfcb48f0a06a40fa1af46ebc,tokens,3.1
0x95ced938f7991cd0dfcb48f0a06a40fa1af46ebc,tokens,4.2

Added 1 address, warning shows 2

dennis00010011b commented 5 years ago

@mariano-aguero Warning doesn't contain number of imported addresses if more than 20 addresses were uploaded Warning's text should also contains phrase ' `Reserved tokens imported Tokens will be reserved for N addresses'

gabitoesmiapodo commented 5 years ago

@mariano-aguero

Just a little issue (I don't know if this got to be fixed here, or in a new issue): if you upload an empty file you get a message "0 tokens imported blah blah".

I think it would be better to display some meaningful error when this happens, for example: "Empty CSV file. Nothing was imported.", or something like that.

screen shot 2018-10-01 at 09 50 26

I fixed this mobile version's UI issue.

Before:

screen shot 2018-10-01 at 09 55 02

After:

screen shot 2018-10-01 at 10 07 44

mariano-aguero commented 5 years ago

@dennis00010011b

If CSV file contains rows with the same address and dimension but different values then will be added only one address (which latest). In this case warning contains incorrect number of added addresses

Done

mariano-aguero commented 5 years ago

@dennis00010011b

Validator of uploaded CSV detects errors but there is no warning message in cases if :+1: typo in dimension unit incorrect value (typo or negative) numbers of column more than 3

Done

mariano-aguero commented 5 years ago

@dennis00010011b

Warning doesn't contain number of imported addresses if more than 20 addresses were uploaded Warning's text should also contains phrase ' `Reserved tokens imported Tokens will be reserved for N addresses'

Done

mariano-aguero commented 5 years ago

@dennis00010011b

I think it would be better to display some meaningful error when this happens, for example: "Empty CSV file. Nothing was imported.", or something like that.

Done