search

poanetwork / token-wizard

(Discontinued) TokenWizard is an DApp to create and manage crowdsale and token contracts using a simple UI
MIT License
381 stars 216 forks source link

(Bug) TW 2.0 doesn't work with Ganache-cli #1168

Closed mariano-aguero closed 5 years ago

mariano-aguero commented 5 years ago

Closes #1162

How to test it: Try to reproduce the problem described in the related issue

fernandomg commented 5 years ago

@mariano-aguero I'm getting the 'Warning' modal for the no-wallet available appearing on every page transition (when step1, step2, etc loads, the modal appears), is it expected?

mariano-aguero commented 5 years ago

@fernandomg

I'm getting the 'Warning' modal for the no-wallet available appearing on every page transition (when step1, step2, etc loads, the modal appears), is it expected?

Yes, because there is no wallet and it is the previous behavior

Regards

vbaranov commented 5 years ago

@mariano-aguero

I'm getting the 'Warning' modal for the no-wallet available appearing on every page transition (when step1, step2, etc loads, the modal appears), is it expected?

Indeed, I see the same. It is not the best developer's experience, from my perspective. It is also a part of the original issue https://github.com/poanetwork/token-wizard/issues/1162:

I see warning messages, that wallet is not installed.

Can we remove the warnings during the launch of TW with ganahe-cli?

Also, I see the warning on the contribution page. It should not be there neither with ganache-cli nor with MM/NW, because users are able to contribute by means of QR-code. Thus, having the wallet is not mandatory:

screen shot 2018-10-16 at 17 17 22

mariano-aguero commented 5 years ago

@vbaranov @dennis00010011b @fernandomg

Removed warnings on development enviroment, and in the contribution page

Regards

dennis00010011b commented 5 years ago

Tested it. No issues were found