poanetwork / token-wizard

(Discontinued) TokenWizard is an DApp to create and manage crowdsale and token contracts using a simple UI
MIT License
381 stars 216 forks source link

(Fix) Update DApp loading code considering upcoming Breaking Change in MetaMask (Branch Master) #1171

Closed mariano-aguero closed 5 years ago

mariano-aguero commented 5 years ago

Closes #1165 .

Modify the "MetaMask not found" error page to display a generic error text stating "Wallet not found, or access to Ethereum account not granted"

This is for the master branch, there will be another PR for the branch 2.0

screenshot_20181012_152956

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 3263


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/stores/Web3Store.js 4 12 33.33%
src/react-web3/Web3Provider.js 12 27 44.44%
<!-- Total: 16 39 41.03% -->
Files with Coverage Reduction New Missed Lines %
src/components/Common/StepNavigation.js 1 66.67%
src/components/stats/index.js 1 0.0%
src/components/stepOne/index.js 1 8.11%
src/react-web3/Web3Provider.js 1 36.47%
src/components/Common/WhenFieldChanges.js 2 14.29%
src/components/stepThree/GasPriceInput.js 2 0.0%
src/components/stepThree/StepThreeForm.js 2 12.5%
src/components/stepTwo/index.js 2 7.41%
src/components/Common/TierBlock.js 3 9.68%
src/components/Common/TxProgressStatus.js 3 0.0%
<!-- Total: 625 -->
Totals Coverage Status
Change from base Build 3099: 4.05%
Covered Lines: 736
Relevant Lines: 2944

💛 - Coveralls
vbaranov commented 5 years ago

@mariano-aguero

Double dots: screen shot 2018-10-16 at 13 54 55

and let's change the link to Token Wizard wiki

mariano-aguero commented 5 years ago

@vbaranov

Double dots: and let's change the link to Token Wizard wiki

Done!

mariano-aguero commented 5 years ago

@dennis00010011b

Manage page isn't fully rendered unless clicking button 'Finalize'

It is not an error related to the changes made it, anyway I solved in this branch

Regards

mariano-aguero commented 5 years ago

@dennis00010011b

Do not merge until @fernandomg do the code review

dennis00010011b commented 5 years ago

I can't get "MetaMask not found" error page with local build. As a result app crashed on Step 2. https://www.useloom.com/share/8d421012f09940f291ad75c79fb91015

screen shot 2018-10-19 at 10 35 48 am
mariano-aguero commented 5 years ago

@dennis00010011b

I can't get "MetaMask not found" error page with local build. As a result app crashed on Step 2.

Fixed