poanetwork / token-wizard

(Discontinued) TokenWizard is an DApp to create and manage crowdsale and token contracts using a simple UI
MIT License
381 stars 216 forks source link

(Feature) Consider download contract info zip file from manage page #1175

Closed fernandomg closed 5 years ago

fernandomg commented 5 years ago

Closes #627

In this PR besides moving all the downloadCrowdsaleInfo to its own utility file, I took the opportunity to refactor it a bit so it's a bit easier to maintain/extend.

Also did the following fixes:

dennis00010011b commented 5 years ago

@fernandomg Minted - Manage page: downloaded file MintedCappedCrowdsale_data.txt contains incorrect info:

  1. Crowdsale end time
  2. Crowdsale hard cap (last tier's hard cap instead total hard cap)

Also modifying of crowdsale's end time aren't reflected in file MintedCappedCrowdsale_data.txt

Paameters of crowdsale: minted , 2 tiers, start/end time by default, no whitelist

screen shot 2018-10-14 at 11 43 54 am

it is also actual for Dutch

screen shot 2018-10-14 at 1 25 51 pm
dennis00010011b commented 5 years ago

@fernandomg Crowdsale parameters: Minted, 2 tiers, no whitelist, both tiers modifiable Steps:

  1. Change moncap for tier #1
  2. Download files and observe file 002_tier.txt Result : Min cap value in file 002_tier.txt changed after modifying mincap for tier #1
screen shot 2018-10-14 at 12 04 01 pm
dennis00010011b commented 5 years ago

@fernandomg Whitelist's table is messed in file ###_tier.txt. It is actual for files downloaded from publish page too. There are symbol , instead \n

screen shot 2018-10-14 at 12 29 02 pm

Device: MacBookPro, MacOS, High Sierra 10.13.6

fernandomg commented 5 years ago

@dennis00010011b,

dennis00010011b commented 5 years ago

@fernandomg Auth-os_addresses.txt file : double lines for Auth-os SaleManager address, Auth-os TokenManager address

screen shot 2018-10-16 at 10 24 01 am
dennis00010011b commented 5 years ago

@fernandomg Should encoded ABI parameters be changed if crowdsale's start/end time was changed? They aren't updated in file

fernandomg commented 5 years ago

Should encoded ABI parameters be changed if crowdsale's start/end time was changed? They aren't updated in file

@dennis00010011b you can check, from the following block that the ABI params do not depend on those values: https://github.com/poanetwork/token-wizard/blob/2.0/src/components/stepFour/utils.js#L64-L76

fernandomg commented 5 years ago

Auth-os_addresses.txt file : double lines for Auth-os SaleManager address, Auth-os TokenManager address

Fixed. Thanks for that catch