search

poanetwork / token-wizard

(Discontinued) TokenWizard is an DApp to create and manage crowdsale and token contracts using a simple UI
MIT License
384 stars 215 forks source link

(Fix) Update DApp loading code considering upcoming Breaking Change in MetaMask (Branch Integration Design) #1177

Closed mariano-aguero closed 5 years ago

mariano-aguero commented 5 years ago

Part of #1165 .

Modify the "MetaMask not found" error page to display a generic error text stating "Wallet not found, or access to Ethereum account not granted"

This is for the Integration design branch, I will create an issue for the design of this section

BlackDuckCoPilot commented 5 years ago

Black Duck Security Report

Merging #1177 into integration/#1082-new-design will not change security risk.

Click here to see full report

fernandomg commented 5 years ago

@mariano-aguero, please, solve conflicts

mariano-aguero commented 5 years ago

Issue created #1178

dennis00010011b commented 5 years ago

@mariano-aguero Instruction's link leads to Google store, not to Wiki Github

screen shot 2018-10-18 at 9 13 32 am
mariano-aguero commented 5 years ago

@dennis00010011b

Instruction's link leads to Google store, not to Wiki Github

Fixed

mariano-aguero commented 5 years ago

@dennis00010011b @fernandomg

Some tests of the web3store are failing, please do not close or merge this branch until that is solved

mariano-aguero commented 5 years ago

Added tests for web3Store and incremented coverage

dennis00010011b commented 5 years ago

@mariano-aguero Unit tests still failed https://travis-ci.org/poanetwork/token-wizard/jobs/448090484

mariano-aguero commented 5 years ago

@dennis00010011b

Unit tests still failed https://travis-ci.org/poanetwork/token-wizard/jobs/448090484

Yes, this tests are broken because the facelifting These tests are being worked on in this separate branch: 1169-test-step3-after-facelifting