search

poanetwork / token-wizard

(Discontinued) TokenWizard is an DApp to create and manage crowdsale and token contracts using a simple UI
MIT License
381 stars 216 forks source link

(Bug) User can add whitelist if supply is not set in DutchAuction Strategy #1183

Closed fernandomg closed 5 years ago

fernandomg commented 5 years ago

Problem: If the user adds a whitelist address before touching the 'supply' value. Values validations passes, supply is disabled and user can't continue.

Solution: Validate maxValue against supply as it's done in MintedCapped Strategy.

I think we should fix this directly in the redesign branch.

image image

dennis00010011b commented 5 years ago

https://github.com/poanetwork/token-wizard/pull/1172#issuecomment-430494723

fernandomg commented 5 years ago

Oh, thanks @dennis00010011b... I missed that. So let's have it as a separate issue. As this can be reproduced in 2.0 as well.

mariano-aguero commented 5 years ago

@dennis00010011b

See https://github.com/poanetwork/token-wizard/pull/1234

Regards