poanetwork / token-wizard

(Discontinued) TokenWizard is an DApp to create and manage crowdsale and token contracts using a simple UI
MIT License
384 stars 215 forks source link

(Fix) Home [New Crowdsale] button is not cleaning the localStorage #1185

Closed mariano-aguero closed 5 years ago

mariano-aguero commented 5 years ago

Closes #1182

dennis00010011b commented 5 years ago

@mariano-aguero Minted: Step 2 page doesn't keep state if move back/forward https://www.useloom.com/share/3667c17b686441eab8300ede3987c653 Steps:

  1. Start new crowdsale
    1. Select Minted, continue
    2. Fill out fields name and ticker on Step 2
    3. Upload file with reserved addresses
    4. Go back using browser's button
    5. Go forward using browser's button Expected result: reserved addresses, fields name and ticker on Step 2 should keep previously entered data
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 3311


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/StepOne/index.js 0 2 0.0%
<!-- Total: 0 2 0.0% -->
Totals Coverage Status
Change from base Build 3285: -0.02%
Covered Lines: 1292
Relevant Lines: 4054

💛 - Coveralls
BlackDuckCoPilot commented 5 years ago

Black Duck Security Report

Merging #1185 into integration/#1082-new-design will not change security risk.

Click here to see full report

mariano-aguero commented 5 years ago

@dennis00010011b

Minted: Step 2 page doesn't keep state if move back/forward

Solved, checked tests

screenshot_20181018_152057

dennis00010011b commented 5 years ago

@mariano-aguero Same things with Step 1: page doesn't keep state if move back/forward https://www.useloom.com/share/2f482e5152c1453aaedc55177159d003

mariano-aguero commented 5 years ago

@dennis00010011b

Same things with Step 1: page doesn't keep state if move back/forward

Done