search

poanetwork / token-wizard

(Discontinued) TokenWizard is an DApp to create and manage crowdsale and token contracts using a simple UI
MIT License
381 stars 216 forks source link

(Feature) Step 3 - CSV File Upload Improvements #1207

Closed mariano-aguero closed 5 years ago

mariano-aguero commented 5 years ago

Closes #1179

BlackDuckCoPilot commented 5 years ago

Black Duck Security Report

Merging #1207 into integration/#1082-new-design will not change security risk.

Click here to see full report

dennis00010011b commented 5 years ago

@mariano-aguero Validator detects incorrect minCap for line with incorrect maxCap

screen shot 2018-10-31 at 6 00 13 pm
dennis00010011b commented 5 years ago

@mariano-aguero Warning message: if warning contains one error then the text should be in singular form ... is wrong (instead ... are wrong)

screen shot 2018-10-31 at 6 03 07 pm screen shot 2018-10-31 at 6 09 16 pm

And has instead have if only one line

screen shot 2018-10-31 at 6 23 58 pm
dennis00010011b commented 5 years ago

@mariano-aguero If mincap is fractional then warning text should contains:

screen shot 2018-10-31 at 6 12 39 pm
dennis00010011b commented 5 years ago

@mariano-aguero Why not to add ta phrase actual value is.. to each incorrect line in this warning message if it has already added in similar case with wrong mincap?

screen shot 2018-10-31 at 6 42 52 pm
mariano-aguero commented 5 years ago

@dennis00010011b

All feedback reported was fixed, Greetings

dennis00010011b commented 5 years ago

@mariano-aguero Error messages are duplicated if line has no minCap or maxCap

screen shot 2018-11-01 at 1 03 51 pm screen shot 2018-11-01 at 1 08 02 pm
mariano-aguero commented 5 years ago

@dennis00010011b all errors belong to that line. Do you want the errors to be grouped by line?

dennis00010011b commented 5 years ago

@mariano-aguero Follow messages are dublicates. The line number 5 need a minCap and The line number 5 has an incorrect mincap. Must be an integer. Actual value is empty I think should be only one of them (second)

mariano-aguero commented 5 years ago

@dennis00010011b

Follow messages are dublicates. The line number 5 need a minCap and The line number 5 has an incorrect mincap. Must be an integer. Actual value is empty I think should be only one of them (second)

I did a simulation with your test file, I attached a capture.

screenshot_20181102_185258

gabitoesmiapodo commented 5 years ago

Fixed a conflict with the integration branch.

gabitoesmiapodo commented 5 years ago

@mariano-aguero

It seems to work fine.

I suggest a few changes:

1- It may be good to change

- The line number 1...
- The line number 2...
- The line number 3...

etc.

For a simpler and less cluttered

- Line #1... 
- Line #4...
- Line #6...

etc.

2- I might be nitpicking, but I think that "Current value is..." is more adequate than "Actual value is..."

3- Must be a integer should be Must be an integer

mariano-aguero commented 5 years ago

@gabitoesmiapodo

Wording fixed here https://github.com/poanetwork/token-wizard/pull/1207/commits/d7bfa0fc477f47ad41d641b220cce66c571bab75

Greetings